[U-Boot] [U-Boot, v2, 4/5] gpt: part: Definition and declaration of GPT verification functions

From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 4/5] gpt: part: Definition and declaration of GPT verification functions
Date: Tue, 24 Nov 2015 10:56:41 +0100	[thread overview]
Message-ID: <56543459.2050207@samsung.com> (raw)
In-Reply-To: <20151123224443.GA9551@bill-the-cat>

Hello Tom,

On 11/23/2015 11:44 PM, Tom Rini wrote:
> On Fri, Nov 20, 2015 at 08:06:16AM +0100, Lukasz Majewski wrote:
>
>> This commit provides definition and declaration of GPT verification
>> functions - namely gpt_verify_headers() and gpt_verify_partitions().
>> The former is used to only check CRC32 of GPT's header and PTEs.
>> The latter examines each partition entry and compare attributes such as:
>> name, start offset and size with ones provided at '$partitions' env
>> variable.
>>
>> Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>> Reviewed-by: Przemyslaw Marczak <p.marczak@samsung.com>
>
> Applied to u-boot/master, thanks!
>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

Why merged so quickly?

I tested this patchset on my device and posted about the issues. [1]

This should be reworked, since the verify assumptions are too simple and 
doesn't fully match the GPT header creation.
So this command will fail for some cases of write/verify sequence, 
depending on what the $partitions includes.

[1] https://www.mail-archive.com/u-boot at lists.denx.de/msg193216.html

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com