* [U-Boot] [PATCH v1] armv8: fsl-layerscape: Fix "cpu release" command
@ 2015-11-12 20:38 York Sun
2015-11-30 17:18 ` York Sun
0 siblings, 1 reply; 2+ messages in thread
From: York Sun @ 2015-11-12 20:38 UTC (permalink / raw)
To: u-boot
When one core is released, other cores may not have valid entry
address. Those cores are trapped by "wfe" and wait for further
instruction. When their address is set, they need to be kicked
off by "sev".
Signed-off-by: York Sun <yorksun@freescale.com>
---
arch/arm/cpu/armv8/fsl-layerscape/mp.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/mp.c b/arch/arm/cpu/armv8/fsl-layerscape/mp.c
index 0d600db..df7ffb8 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/mp.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/mp.c
@@ -192,6 +192,12 @@ int cpu_release(int nr, int argc, char * const argv[])
(unsigned long)table + SPIN_TABLE_ELEM_SIZE);
asm volatile("dsb st");
smp_kick_all_cpus(); /* only those with entry addr set will run */
+ /*
+ * When the first release command runs, all cores are set to go. Those
+ * without a valid entry address will be trapped by "wfe". "sev" kicks
+ * them off to check the address again. When set, they continue to run.
+ */
+ asm volatile("sev");
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v1] armv8: fsl-layerscape: Fix "cpu release" command
2015-11-12 20:38 [U-Boot] [PATCH v1] armv8: fsl-layerscape: Fix "cpu release" command York Sun
@ 2015-11-30 17:18 ` York Sun
0 siblings, 0 replies; 2+ messages in thread
From: York Sun @ 2015-11-30 17:18 UTC (permalink / raw)
To: u-boot
On 11/12/2015 12:38 PM, York Sun wrote:
> When one core is released, other cores may not have valid entry
> address. Those cores are trapped by "wfe" and wait for further
> instruction. When their address is set, they need to be kicked
> off by "sev".
>
> Signed-off-by: York Sun <yorksun@freescale.com>
>
> ---
>
> arch/arm/cpu/armv8/fsl-layerscape/mp.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Applied to fsl-qoriq master.
York
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-30 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-12 20:38 [U-Boot] [PATCH v1] armv8: fsl-layerscape: Fix "cpu release" command York Sun
2015-11-30 17:18 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox