[U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry

[U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry

[Marek Vasut]

The DM entry should be unique, otherwise it will collide with other
drivers. Fix this by assigning the driver a more unique name than
usb_ehci.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Ian Campbell <ijc@hellion.org.uk>
Cc: Simon Glass <sjg@chromium.org>
---
 drivers/usb/host/ehci-sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-sunxi.c b/drivers/usb/host/ehci-sunxi.c
index 38d5f92..d494ca1 100644
--- a/drivers/usb/host/ehci-sunxi.c
+++ b/drivers/usb/host/ehci-sunxi.c
@@ -87,7 +87,7 @@ static const struct udevice_id ehci_usb_ids[] = {
 	{ }
 };
 
-U_BOOT_DRIVER(usb_ehci) = {
+U_BOOT_DRIVER(ehci_sunxi) = {
 	.name	= "ehci_sunxi",
 	.id	= UCLASS_USB,
 	.of_match = ehci_usb_ids,
-- 
2.1.4

[U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry

[Hans de Goede]

Hi,

On 30-11-15 18:19, Marek Vasut wrote:
> The DM entry should be unique, otherwise it will collide with other
> drivers. Fix this by assigning the driver a more unique name than
> usb_ehci.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Simon Glass <sjg@chromium.org>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Marek, do you want me to take this upstream through the
u-boot-sunxi tree, or will you pick this up yourself ?

Regards,

Hans




> ---
>   drivers/usb/host/ehci-sunxi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-sunxi.c b/drivers/usb/host/ehci-sunxi.c
> index 38d5f92..d494ca1 100644
> --- a/drivers/usb/host/ehci-sunxi.c
> +++ b/drivers/usb/host/ehci-sunxi.c
> @@ -87,7 +87,7 @@ static const struct udevice_id ehci_usb_ids[] = {
>   	{ }
>   };
>
> -U_BOOT_DRIVER(usb_ehci) = {
> +U_BOOT_DRIVER(ehci_sunxi) = {
>   	.name	= "ehci_sunxi",
>   	.id	= UCLASS_USB,
>   	.of_match = ehci_usb_ids,
>

[U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry

[Marek Vasut]

On Tuesday, December 01, 2015 at 09:27:59 AM, Hans de Goede wrote:
> Hi,
> 
> On 30-11-15 18:19, Marek Vasut wrote:
> > The DM entry should be unique, otherwise it will collide with other
> > drivers. Fix this by assigning the driver a more unique name than
> > usb_ehci.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Ian Campbell <ijc@hellion.org.uk>
> > Cc: Simon Glass <sjg@chromium.org>
> 
> Looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> Marek, do you want me to take this upstream through the
> u-boot-sunxi tree, or will you pick this up yourself ?

I'll pick it through the USB at it fixes build issue there.
Thanks!

Best regards,
Marek Vasut