* [U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry
@ 2015-11-30 17:19 Marek Vasut
2015-12-01 8:27 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2015-11-30 17:19 UTC (permalink / raw)
To: u-boot
The DM entry should be unique, otherwise it will collide with other
drivers. Fix this by assigning the driver a more unique name than
usb_ehci.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Ian Campbell <ijc@hellion.org.uk>
Cc: Simon Glass <sjg@chromium.org>
---
drivers/usb/host/ehci-sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-sunxi.c b/drivers/usb/host/ehci-sunxi.c
index 38d5f92..d494ca1 100644
--- a/drivers/usb/host/ehci-sunxi.c
+++ b/drivers/usb/host/ehci-sunxi.c
@@ -87,7 +87,7 @@ static const struct udevice_id ehci_usb_ids[] = {
{ }
};
-U_BOOT_DRIVER(usb_ehci) = {
+U_BOOT_DRIVER(ehci_sunxi) = {
.name = "ehci_sunxi",
.id = UCLASS_USB,
.of_match = ehci_usb_ids,
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry
2015-11-30 17:19 [U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry Marek Vasut
@ 2015-12-01 8:27 ` Hans de Goede
2015-12-01 13:13 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2015-12-01 8:27 UTC (permalink / raw)
To: u-boot
Hi,
On 30-11-15 18:19, Marek Vasut wrote:
> The DM entry should be unique, otherwise it will collide with other
> drivers. Fix this by assigning the driver a more unique name than
> usb_ehci.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Simon Glass <sjg@chromium.org>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Marek, do you want me to take this upstream through the
u-boot-sunxi tree, or will you pick this up yourself ?
Regards,
Hans
> ---
> drivers/usb/host/ehci-sunxi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-sunxi.c b/drivers/usb/host/ehci-sunxi.c
> index 38d5f92..d494ca1 100644
> --- a/drivers/usb/host/ehci-sunxi.c
> +++ b/drivers/usb/host/ehci-sunxi.c
> @@ -87,7 +87,7 @@ static const struct udevice_id ehci_usb_ids[] = {
> { }
> };
>
> -U_BOOT_DRIVER(usb_ehci) = {
> +U_BOOT_DRIVER(ehci_sunxi) = {
> .name = "ehci_sunxi",
> .id = UCLASS_USB,
> .of_match = ehci_usb_ids,
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry
2015-12-01 8:27 ` Hans de Goede
@ 2015-12-01 13:13 ` Marek Vasut
0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2015-12-01 13:13 UTC (permalink / raw)
To: u-boot
On Tuesday, December 01, 2015 at 09:27:59 AM, Hans de Goede wrote:
> Hi,
>
> On 30-11-15 18:19, Marek Vasut wrote:
> > The DM entry should be unique, otherwise it will collide with other
> > drivers. Fix this by assigning the driver a more unique name than
> > usb_ehci.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Ian Campbell <ijc@hellion.org.uk>
> > Cc: Simon Glass <sjg@chromium.org>
>
> Looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Marek, do you want me to take this upstream through the
> u-boot-sunxi tree, or will you pick this up yourself ?
I'll pick it through the USB at it fixes build issue there.
Thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-01 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-30 17:19 [U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry Marek Vasut
2015-12-01 8:27 ` Hans de Goede
2015-12-01 13:13 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox