public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] dm: core: Enable SPL_SIMPLE_BUS by default
@ 2015-12-01  7:39 Michal Simek
  2015-12-01  7:46 ` Stefan Roese
  2015-12-01 16:32 ` Simon Glass
  0 siblings, 2 replies; 4+ messages in thread
From: Michal Simek @ 2015-12-01  7:39 UTC (permalink / raw)
  To: u-boot

This option is needed for all SoCs which have nodes on bus. Without
enabling this drivers are not found and probed.
Issue was found on Zynq MMC probe.
Enable this option by default.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
index 15681df6d379..74eee1066092 100644
--- a/drivers/core/Kconfig
+++ b/drivers/core/Kconfig
@@ -115,7 +115,7 @@ config SIMPLE_BUS
 config SPL_SIMPLE_BUS
 	bool "Support simple-bus driver in SPL"
 	depends on SPL_DM && SPL_OF_CONTROL
-	default n
+	default y
 	help
 	  Supports the 'simple-bus' driver, which is used on some systems
 	  in SPL.
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] dm: core: Enable SPL_SIMPLE_BUS by default
  2015-12-01  7:39 [U-Boot] [PATCH] dm: core: Enable SPL_SIMPLE_BUS by default Michal Simek
@ 2015-12-01  7:46 ` Stefan Roese
  2015-12-01 10:22   ` Michal Simek
  2015-12-01 16:32 ` Simon Glass
  1 sibling, 1 reply; 4+ messages in thread
From: Stefan Roese @ 2015-12-01  7:46 UTC (permalink / raw)
  To: u-boot

Hi Michal,

On 01.12.2015 08:39, Michal Simek wrote:
> This option is needed for all SoCs which have nodes on bus. Without
> enabling this drivers are not found and probed.
> Issue was found on Zynq MMC probe.
> Enable this option by default.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>   drivers/core/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
> index 15681df6d379..74eee1066092 100644
> --- a/drivers/core/Kconfig
> +++ b/drivers/core/Kconfig
> @@ -115,7 +115,7 @@ config SIMPLE_BUS
>   config SPL_SIMPLE_BUS
>   	bool "Support simple-bus driver in SPL"
>   	depends on SPL_DM && SPL_OF_CONTROL
> -	default n
> +	default y
>   	help
>   	  Supports the 'simple-bus' driver, which is used on some systems
>   	  in SPL.

I stumbled over this missing option while porting DM_SPL to mvebu
as well. So:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] dm: core: Enable SPL_SIMPLE_BUS by default
  2015-12-01  7:46 ` Stefan Roese
@ 2015-12-01 10:22   ` Michal Simek
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2015-12-01 10:22 UTC (permalink / raw)
  To: u-boot

On 1.12.2015 08:46, Stefan Roese wrote:
> Hi Michal,
> 
> On 01.12.2015 08:39, Michal Simek wrote:
>> This option is needed for all SoCs which have nodes on bus. Without
>> enabling this drivers are not found and probed.
>> Issue was found on Zynq MMC probe.
>> Enable this option by default.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>   drivers/core/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
>> index 15681df6d379..74eee1066092 100644
>> --- a/drivers/core/Kconfig
>> +++ b/drivers/core/Kconfig
>> @@ -115,7 +115,7 @@ config SIMPLE_BUS
>>   config SPL_SIMPLE_BUS
>>       bool "Support simple-bus driver in SPL"
>>       depends on SPL_DM && SPL_OF_CONTROL
>> -    default n
>> +    default y
>>       help
>>         Supports the 'simple-bus' driver, which is used on some systems
>>         in SPL.
> 
> I stumbled over this missing option while porting DM_SPL to mvebu
> as well. So:
> 
> Reviewed-by: Stefan Roese <sr@denx.de>

yep. btw: I have added you to cc to one more email regarding SPL.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] dm: core: Enable SPL_SIMPLE_BUS by default
  2015-12-01  7:39 [U-Boot] [PATCH] dm: core: Enable SPL_SIMPLE_BUS by default Michal Simek
  2015-12-01  7:46 ` Stefan Roese
@ 2015-12-01 16:32 ` Simon Glass
  1 sibling, 0 replies; 4+ messages in thread
From: Simon Glass @ 2015-12-01 16:32 UTC (permalink / raw)
  To: u-boot

On 1 December 2015 at 00:39, Michal Simek <michal.simek@xilinx.com> wrote:
> This option is needed for all SoCs which have nodes on bus. Without
> enabling this drivers are not found and probed.
> Issue was found on Zynq MMC probe.
> Enable this option by default.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/core/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-12-01 16:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-01  7:39 [U-Boot] [PATCH] dm: core: Enable SPL_SIMPLE_BUS by default Michal Simek
2015-12-01  7:46 ` Stefan Roese
2015-12-01 10:22   ` Michal Simek
2015-12-01 16:32 ` Simon Glass

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox