* [U-Boot] [PATCH] net: gem: Enable CTRL+C in wait_for_bit
@ 2015-11-26 9:46 Michal Simek
2015-11-30 20:36 ` Joe Hershberger
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2015-11-26 9:46 UTC (permalink / raw)
To: u-boot
Enable to break waiting loop at any time.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/net/zynq_gem.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 858093f0d7e2..ee4169107e5b 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -447,6 +447,11 @@ static int wait_for_bit(const char *func, u32 *reg, const u32 mask,
if (get_timer(start) > timeout)
break;
+ if (ctrlc()) {
+ puts("Abort\n");
+ return -1;
+ }
+
udelay(1);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] net: gem: Enable CTRL+C in wait_for_bit
2015-11-26 9:46 [U-Boot] [PATCH] net: gem: Enable CTRL+C in wait_for_bit Michal Simek
@ 2015-11-30 20:36 ` Joe Hershberger
2015-12-01 10:35 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Joe Hershberger @ 2015-11-30 20:36 UTC (permalink / raw)
To: u-boot
Hi Michal,
On Thu, Nov 26, 2015 at 3:46 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> Enable to break waiting loop at any time.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/net/zynq_gem.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index 858093f0d7e2..ee4169107e5b 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -447,6 +447,11 @@ static int wait_for_bit(const char *func, u32 *reg, const u32 mask,
> if (get_timer(start) > timeout)
> break;
>
> + if (ctrlc()) {
> + puts("Abort\n");
> + return -1;
Maybe this should return -EINTR?
> + }
> +
> udelay(1);
> }
>
> --
> 1.9.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] net: gem: Enable CTRL+C in wait_for_bit
2015-11-30 20:36 ` Joe Hershberger
@ 2015-12-01 10:35 ` Michal Simek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2015-12-01 10:35 UTC (permalink / raw)
To: u-boot
On 30.11.2015 21:36, Joe Hershberger wrote:
> Hi Michal,
>
> On Thu, Nov 26, 2015 at 3:46 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> Enable to break waiting loop at any time.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> drivers/net/zynq_gem.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
>> index 858093f0d7e2..ee4169107e5b 100644
>> --- a/drivers/net/zynq_gem.c
>> +++ b/drivers/net/zynq_gem.c
>> @@ -447,6 +447,11 @@ static int wait_for_bit(const char *func, u32 *reg, const u32 mask,
>> if (get_timer(start) > timeout)
>> break;
>>
>> + if (ctrlc()) {
>> + puts("Abort\n");
>> + return -1;
>
> Maybe this should return -EINTR?
No problem with this.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-01 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 9:46 [U-Boot] [PATCH] net: gem: Enable CTRL+C in wait_for_bit Michal Simek
2015-11-30 20:36 ` Joe Hershberger
2015-12-01 10:35 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox