From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mx6: fix reg base address when runtime usage
Date: Tue, 1 Dec 2015 16:13:00 +0100 [thread overview]
Message-ID: <565DB8FC.5090004@denx.de> (raw)
In-Reply-To: <1448870691-23115-1-git-send-email-Peng.Fan@freescale.com>
On 30/11/2015 09:04, Peng Fan wrote:
> Should use parenthese to wrap the macro definition, otherwise
> we will encounter error like the following:
>
> "
> if (base_addr != LCDIF1_BASE_ADDR) {
> puts("Wrong LCD interface!\n");
> return -EINVAL;
> }
> "
>
> Without this patch, we will always encounter "Wrong LCD interface".
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> arch/arm/include/asm/arch-mx6/imx-regs.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h b/arch/arm/include/asm/arch-mx6/imx-regs.h
> index 2f068e5..f24525e 100644
> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
> @@ -335,10 +335,10 @@
> #include <asm/types.h>
>
> /* only for i.MX6SX/UL */
> -#define WDOG3_BASE_ADDR (is_cpu_type(MXC_CPU_MX6UL) ? \
> - MX6UL_WDOG3_BASE_ADDR : MX6SX_WDOG3_BASE_ADDR)
> -#define LCDIF1_BASE_ADDR (is_cpu_type(MXC_CPU_MX6UL)) ? \
> - MX6UL_LCDIF1_BASE_ADDR : MX6SX_LCDIF1_BASE_ADDR
> +#define WDOG3_BASE_ADDR ((is_cpu_type(MXC_CPU_MX6UL) ? \
> + MX6UL_WDOG3_BASE_ADDR : MX6SX_WDOG3_BASE_ADDR))
> +#define LCDIF1_BASE_ADDR ((is_cpu_type(MXC_CPU_MX6UL)) ? \
> + MX6UL_LCDIF1_BASE_ADDR : MX6SX_LCDIF1_BASE_ADDR)
>
>
> extern void imx_get_mac_from_fuse(int dev_id, unsigned char *mac);
>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2015-12-01 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 8:04 [U-Boot] [PATCH] imx: mx6: fix reg base address when runtime usage Peng Fan
2015-12-01 15:13 ` Stefano Babic [this message]
2015-12-07 14:03 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DB8FC.5090004@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox