From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] arm: Add sata support on Layerscape ARMv8 board
Date: Tue, 1 Dec 2015 08:58:36 -0800 [thread overview]
Message-ID: <565DD1BC.7010207@freescale.com> (raw)
In-Reply-To: <565DD0C5.8060203@writeme.com>
On 12/01/2015 08:54 AM, Sinan Akman wrote:
>
> Hi York
>
> On 01/12/15 11:44 AM, York Sun wrote:
>> Sinan,
>>
>> Thanks for your review.
>>
>> Yuantian,
>>
>> You are right about putting things together. We have some macros in wrong
>> places, including config.h. If you can, please try to move them into proper
>> files, such as immap_lsch3.h. Enabling SATA should be done at board level
>> because it depends on the board to have physical connection.
>
> Just to make this clear one final time, I am not against enabling
> SATA at the board level but
> my suggestion is to define the SATA register values (which is *not*
> board dependent) in the
> soc specific header file, then at the board level if SATA is not enabled
> we don't use it, if it is
> enabled we use it and use the same register values across all boards
> with this SoC. That's all.
>
Agreed.
York
next prev parent reply other threads:[~2015-12-01 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 7:44 [U-Boot] [PATCH v4] arm: Add sata support on Layerscape ARMv8 board Yuantian.Tang at freescale.com
2015-11-30 17:27 ` Sinan Akman
2015-12-01 6:16 ` Yuantian Tang
2015-12-01 6:29 ` Sinan Akman
2015-12-01 6:41 ` Yuantian Tang
2015-12-01 7:23 ` Sinan Akman
2015-12-01 8:36 ` Yuantian Tang
2015-12-01 14:46 ` Sinan Akman
2015-12-01 16:44 ` York Sun
2015-12-01 16:54 ` Sinan Akman
2015-12-01 16:58 ` York Sun [this message]
2015-12-02 2:42 ` Yuantian Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DD1BC.7010207@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox