From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Tue, 1 Dec 2015 08:58:36 -0800 Subject: [U-Boot] [PATCH v4] arm: Add sata support on Layerscape ARMv8 board In-Reply-To: <565DD0C5.8060203@writeme.com> References: <1448869497-20489-1-git-send-email-Yuantian.Tang@freescale.com> <565C871A.2050702@writeme.com> <565D3E3C.2030303@writeme.com> <565D4B0C.1050206@writeme.com> <565DB2CF.4030908@writeme.com> <565DCE51.609@freescale.com> <565DD0C5.8060203@writeme.com> Message-ID: <565DD1BC.7010207@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/01/2015 08:54 AM, Sinan Akman wrote: > > Hi York > > On 01/12/15 11:44 AM, York Sun wrote: >> Sinan, >> >> Thanks for your review. >> >> Yuantian, >> >> You are right about putting things together. We have some macros in wrong >> places, including config.h. If you can, please try to move them into proper >> files, such as immap_lsch3.h. Enabling SATA should be done at board level >> because it depends on the board to have physical connection. > > Just to make this clear one final time, I am not against enabling > SATA at the board level but > my suggestion is to define the SATA register values (which is *not* > board dependent) in the > soc specific header file, then at the board level if SATA is not enabled > we don't use it, if it is > enabled we use it and use the same register values across all boards > with this SoC. That's all. > Agreed. York