From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Date: Tue, 1 Dec 2015 16:56:29 -0600 Subject: [U-Boot] [PATCHv2 1/9] arm: socfpga: arria10: add system manager defines In-Reply-To: <201512011946.31752.marex@denx.de> References: <1448988519-21669-1-git-send-email-dinguyen@opensource.altera.com> <1448988519-21669-2-git-send-email-dinguyen@opensource.altera.com> <201512011946.31752.marex@denx.de> Message-ID: <565E259D.9050500@opensource.altera.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/01/2015 12:46 PM, Marek Vasut wrote: > On Tuesday, December 01, 2015 at 05:48:31 PM, dinguyen at opensource.altera.com > wrote: >> From: Dinh Nguyen >> >> Add system manager defines for Arria10. >> >> Signed-off-by: Dinh Nguyen >> --- >> v2: clean up parenthesis > > [...] > >> +/* bit fields */ >> +#define SYSMGR_ROMCODEGRP_CTRL_WARMRSTCFGPINMUX (1<<0) >> +#define SYSMGR_ROMCODEGRP_CTRL_WARMRSTCFGIO (1<<1) >> +#define SYSMGR_ECC_OCRAM_EN (1<<0) >> +#define SYSMGR_ECC_OCRAM_SERR (1<<3) >> +#define SYSMGR_ECC_OCRAM_DERR (1<<4) > > Uh, so you have SYSMGR_FPGAINTF_USEFPGA and _SPIM0 here, which use the same > bit. How is this supposed to work ? Is this some specialty of A10 ? > Oops, sorry about that. I didn't clean this up with the idea that reset_manager_a10.c is going away. Thanks, Dinh