[U-Boot] [PATCHv2 1/9] arm: socfpga: arria10: add system manager defines

Dinh Nguyen
2015-12-01T22:56:29Z

On 12/01/2015 12:46 PM, Marek Vasut wrote:
> On Tuesday, December 01, 2015 at 05:48:31 PM, dinguyen at opensource.altera.com
> wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Add system manager defines for Arria10.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
>> ---
>> v2: clean up parenthesis
>
> [...]
>
>> +/* bit fields */
>> +#define SYSMGR_ROMCODEGRP_CTRL_WARMRSTCFGPINMUX (1<<0)
>> +#define SYSMGR_ROMCODEGRP_CTRL_WARMRSTCFGIO (1<<1)
>> +#define SYSMGR_ECC_OCRAM_EN (1<<0)
>> +#define SYSMGR_ECC_OCRAM_SERR (1<<3)
>> +#define SYSMGR_ECC_OCRAM_DERR (1<<4)
>
> Uh, so you have SYSMGR_FPGAINTF_USEFPGA and _SPIM0 here, which use the same
> bit. How is this supposed to work ? Is this some specialty of A10 ?
>

Oops, sorry about that. I didn't clean this up with the idea that
reset_manager_a10.c is going away.

Thanks,
Dinh