From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 1 Dec 2015 21:04:15 -0700 Subject: [U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi In-Reply-To: References: Message-ID: <565E6DBF.1020208@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/28/2015 06:56 PM, Marco Schuster wrote: > This patch re-enables the setexpr command, I don't really understand > why it got excluded in the first place. > > setexpr can be used e.g. to implement failed-boot-counters and > failovers to rescue firmware. > > Two blank lines? > Signed-off-by: Marco Schuster This looks like a reasonable change, but * You should CC the author of the patch that caused this issue (now CC'd) * You should CC the person who would apply this patch (Tom Rini, now CC'd) * You should include a Fixes: tag that specifies the commit that caused this issue; I think: Fixes: ef0f2f57524e ("Move defaults from config_cmd_default.h to Kconfig") * You should double-check all the changes in the original patch in case any other similar issues were introduced. > --- > configs/rpi_2_defconfig | 1 - > configs/rpi_defconfig | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig > index 5c9e69a..bd81ee6 100644 > --- a/configs/rpi_2_defconfig > +++ b/configs/rpi_2_defconfig > @@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " > # CONFIG_CMD_FLASH is not set > # CONFIG_CMD_FPGA is not set > CONFIG_CMD_GPIO=y > -# CONFIG_CMD_SETEXPR is not set > CONFIG_PHYS_TO_BUS=y > diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig > index b8b267f..5d27909 100644 > --- a/configs/rpi_defconfig > +++ b/configs/rpi_defconfig > @@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> " > # CONFIG_CMD_FLASH is not set > # CONFIG_CMD_FPGA is not set > CONFIG_CMD_GPIO=y > -# CONFIG_CMD_SETEXPR is not set > CONFIG_PHYS_TO_BUS=y