* [U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi
@ 2015-11-29 1:56 Marco Schuster
2015-12-02 4:04 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Marco Schuster @ 2015-11-29 1:56 UTC (permalink / raw)
To: u-boot
This patch re-enables the setexpr command, I don't really understand
why it got excluded in the first place.
setexpr can be used e.g. to implement failed-boot-counters and
failovers to rescue firmware.
Signed-off-by: Marco Schuster <m.schuster91@googlemail.com>
---
configs/rpi_2_defconfig | 1 -
configs/rpi_defconfig | 1 -
2 files changed, 2 deletions(-)
diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig
index 5c9e69a..bd81ee6 100644
--- a/configs/rpi_2_defconfig
+++ b/configs/rpi_2_defconfig
@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
# CONFIG_CMD_FLASH is not set
# CONFIG_CMD_FPGA is not set
CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
CONFIG_PHYS_TO_BUS=y
diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig
index b8b267f..5d27909 100644
--- a/configs/rpi_defconfig
+++ b/configs/rpi_defconfig
@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
# CONFIG_CMD_FLASH is not set
# CONFIG_CMD_FPGA is not set
CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
CONFIG_PHYS_TO_BUS=y
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi
2015-11-29 1:56 [U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi Marco Schuster
@ 2015-12-02 4:04 ` Stephen Warren
2015-12-15 17:38 ` Joe Hershberger
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2015-12-02 4:04 UTC (permalink / raw)
To: u-boot
On 11/28/2015 06:56 PM, Marco Schuster wrote:
> This patch re-enables the setexpr command, I don't really understand
> why it got excluded in the first place.
>
> setexpr can be used e.g. to implement failed-boot-counters and
> failovers to rescue firmware.
>
>
Two blank lines?
> Signed-off-by: Marco Schuster <m.schuster91@googlemail.com>
This looks like a reasonable change, but
* You should CC the author of the patch that caused this issue (now CC'd)
* You should CC the person who would apply this patch (Tom Rini, now CC'd)
* You should include a Fixes: tag that specifies the commit that caused
this issue; I think:
Fixes: ef0f2f57524e ("Move defaults from config_cmd_default.h to Kconfig")
* You should double-check all the changes in the original patch in case
any other similar issues were introduced.
> ---
> configs/rpi_2_defconfig | 1 -
> configs/rpi_defconfig | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig
> index 5c9e69a..bd81ee6 100644
> --- a/configs/rpi_2_defconfig
> +++ b/configs/rpi_2_defconfig
> @@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
> # CONFIG_CMD_FLASH is not set
> # CONFIG_CMD_FPGA is not set
> CONFIG_CMD_GPIO=y
> -# CONFIG_CMD_SETEXPR is not set
> CONFIG_PHYS_TO_BUS=y
> diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig
> index b8b267f..5d27909 100644
> --- a/configs/rpi_defconfig
> +++ b/configs/rpi_defconfig
> @@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
> # CONFIG_CMD_FLASH is not set
> # CONFIG_CMD_FPGA is not set
> CONFIG_CMD_GPIO=y
> -# CONFIG_CMD_SETEXPR is not set
> CONFIG_PHYS_TO_BUS=y
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi
2015-12-02 4:04 ` Stephen Warren
@ 2015-12-15 17:38 ` Joe Hershberger
0 siblings, 0 replies; 4+ messages in thread
From: Joe Hershberger @ 2015-12-15 17:38 UTC (permalink / raw)
To: u-boot
On Tue, Dec 1, 2015 at 10:04 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 11/28/2015 06:56 PM, Marco Schuster wrote:
>> This patch re-enables the setexpr command, I don't really understand
>> why it got excluded in the first place.
>>
>> setexpr can be used e.g. to implement failed-boot-counters and
>> failovers to rescue firmware.
>>
>>
>
> Two blank lines?
>
>> Signed-off-by: Marco Schuster <m.schuster91@googlemail.com>
>
> This looks like a reasonable change, but
>
> * You should CC the author of the patch that caused this issue (now CC'd)
>
> * You should CC the person who would apply this patch (Tom Rini, now CC'd)
>
> * You should include a Fixes: tag that specifies the commit that caused
> this issue; I think:
>
> Fixes: ef0f2f57524e ("Move defaults from config_cmd_default.h to Kconfig")
I knew I shouldn't work on that kind of patch. Too easy to miss
something. :/ Maybe modern buildman will help.
> * You should double-check all the changes in the original patch in case
> any other similar issues were introduced.
>
>> ---
>> configs/rpi_2_defconfig | 1 -
>> configs/rpi_defconfig | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig
>> index 5c9e69a..bd81ee6 100644
>> --- a/configs/rpi_2_defconfig
>> +++ b/configs/rpi_2_defconfig
>> @@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
>> # CONFIG_CMD_FLASH is not set
>> # CONFIG_CMD_FPGA is not set
>> CONFIG_CMD_GPIO=y
>> -# CONFIG_CMD_SETEXPR is not set
>> CONFIG_PHYS_TO_BUS=y
>> diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig
>> index b8b267f..5d27909 100644
>> --- a/configs/rpi_defconfig
>> +++ b/configs/rpi_defconfig
>> @@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
>> # CONFIG_CMD_FLASH is not set
>> # CONFIG_CMD_FPGA is not set
>> CONFIG_CMD_GPIO=y
>> -# CONFIG_CMD_SETEXPR is not set
>> CONFIG_PHYS_TO_BUS=y
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi
@ 2015-11-29 18:30 Marco Schuster
0 siblings, 0 replies; 4+ messages in thread
From: Marco Schuster @ 2015-11-29 18:30 UTC (permalink / raw)
To: u-boot
This patch re-enables the setexpr command, I don't really understand
why it got excluded in the first place.
setexpr can be used e.g. to implement failed-boot-counters and
failovers to rescue firmware.
Signed-off-by: Marco Schuster <m.schuster91@googlemail.com>
---
configs/rpi_2_defconfig | 1 -
configs/rpi_defconfig | 1 -
2 files changed, 2 deletions(-)
diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig
index 5c9e69a..bd81ee6 100644
--- a/configs/rpi_2_defconfig
+++ b/configs/rpi_2_defconfig
@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
# CONFIG_CMD_FLASH is not set
# CONFIG_CMD_FPGA is not set
CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
CONFIG_PHYS_TO_BUS=y
diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig
index b8b267f..5d27909 100644
--- a/configs/rpi_defconfig
+++ b/configs/rpi_defconfig
@@ -6,5 +6,4 @@ CONFIG_SYS_PROMPT="U-Boot> "
# CONFIG_CMD_FLASH is not set
# CONFIG_CMD_FPGA is not set
CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
CONFIG_PHYS_TO_BUS=y
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-15 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-29 1:56 [U-Boot] [PATCH] Re-enable setexpr on Raspberry Pi Marco Schuster
2015-12-02 4:04 ` Stephen Warren
2015-12-15 17:38 ` Joe Hershberger
-- strict thread matches above, loose matches on Subject: below --
2015-11-29 18:30 Marco Schuster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox