public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric@nelint.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] mmc erase fails from U-Boot command line
Date: Wed, 2 Dec 2015 12:28:52 -0700	[thread overview]
Message-ID: <565F4674.8010306@nelint.com> (raw)
In-Reply-To: <CAOMZO5C5yTV_KtXxD3im6r5-7RZGSS9VActGdO4mDVc7DmdPyg@mail.gmail.com>

Hi Fabio,

On 12/02/2015 11:52 AM, Fabio Estevam wrote:
> Hi Eric,
> 
> On Wed, Dec 2, 2015 at 4:47 PM, Eric Nelson <eric@nelint.com> wrote:
>> Sure. It's a hack, but shows where we're hitting the problem
>> (with the stop command).
>>
>> We haven't been using the "mmc erase" command, but see this when
>> using ums to program eMMC.
> 
> Ok, applied your patch, but still get:
> 
> => mmc erase 4000 1000
> 
> MMC erase: dev # 2, block # 16384, count 4096 ... Timeout waiting for DAT0 to go
>  high!
> mmc erase failed
> 0 blocks erased: ERROR
> =>
> 

You're hitting the block from a different path than we are and it will
be tomorrow before I can get an offending board on my desk.

What happens if you "#if 0" around this block?

http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/mmc/fsl_esdhc.c;h=c5054d66bdcda029f0485958c87bd5154ccee591;hb=HEAD#l390

Do you know which command is failing? It should be one of these:
	MMC_CMD_ERASE_GROUP_START
	MMC_CMD_ERASE_GROUP_END
	MMC_CMD_ERASE

http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/mmc/mmc_write.c;h=7aea7e943b9e05c8aa537653f4ae8878ecb1b04b;hb=HEAD#l17

I think you can instrument and find out using this:

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 53084a7..8f5d9e1 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -105,6 +105,9 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd
*cmd, struct mmc_data *data)
 #else
        ret = mmc->cfg->ops->send_cmd(mmc, cmd, data);
 #endif
+       if (ret)
+               printf("error %d from CMD_SEND:%d\n", ret, cmd->cmdidx);
+
        return ret;
 }

  reply	other threads:[~2015-12-02 19:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 11:46 [U-Boot] mmc erase fails from U-Boot command line Cliff Brust
2015-10-19 11:06 ` Hector Palacios
2015-11-12 20:56   ` Fabio Estevam
2015-11-13 12:26     ` Palacios, Hector
2015-11-13 14:37       ` Fabio Estevam
2015-11-16 15:23         ` Fabio Estevam
2015-11-16 15:30           ` Fabio Estevam
2015-12-01 19:05             ` Eric Nelson
2015-12-02 17:23               ` Fabio Estevam
2015-12-02 18:47                 ` Eric Nelson
2015-12-02 18:52                   ` Fabio Estevam
2015-12-02 19:28                     ` Eric Nelson [this message]
2015-12-02 19:53                       ` Fabio Estevam
2015-12-04 16:35                         ` Eric Nelson
2015-12-04 16:37                           ` Fabio Estevam
2015-12-04 22:42                           ` Eric Nelson
2015-12-05  0:19                             ` Fabio Estevam
2015-12-07  0:21                             ` Fabio Estevam
2015-12-07 14:36                               ` Eric Nelson
2015-12-02 19:37                     ` Michael Trimarchi
2015-12-02 19:54                       ` Fabio Estevam
2015-12-02 20:00                         ` Michael Trimarchi
2015-12-04 16:08                           ` Eric Nelson
2015-12-04 16:50                             ` Eric Nelson
2015-12-04 17:06                               ` Michael Trimarchi
2015-12-07 14:50                               ` [U-Boot] [PATCH] mmc: update MMC_ERASE argument to match Linux kernel Eric Nelson
2015-12-09 10:55                                 ` Hector Palacios
2015-12-22  9:55                                   ` Fabio Estevam
2016-01-04 22:23                                 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565F4674.8010306@nelint.com \
    --to=eric@nelint.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox