From: Hector Palacios <hector.palacios@digi.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: imx: fsl_esdhc: fix usage of low 4 bits of sysctl register
Date: Fri, 4 Dec 2015 19:25:50 +0100 [thread overview]
Message-ID: <5661DAAE.70106@digi.com> (raw)
In-Reply-To: <5661D0C5.10805@nelint.com>
Hi Eric,
On 12/04/2015 06:43 PM, Eric Nelson wrote:
> On 12/04/2015 10:38 AM, Eric Nelson wrote:
>> On 12/04/2015 10:32 AM, Eric Nelson wrote:
>>> The low four bits of the SYSCTL register are reserved on the USDHC
>>> controller on i.MX6 and i.MX7 processors, but are used for clocking
>>> operations on earlier models.
>>>
>>> Guard against their usage by hiding the bit mask macros on those
>>> processors.
>>>
>>> These bits are used to prevent glitches when changing clocks on
>>> i.MX35 et al. Use the RSTA bit instead for i.MX6 and i.MX7.
>>>
>>> From the i.MX6DQ RM:
>>> To prevent possible glitch on the card clock, clear the
>>> FRC_SDCLK_ON bit when changing clock divisor value(SDCLKFS
>>> or DVS in System Control Register) or setting RSTA bit.
>>>
>>> Signed-off-by: Eric Nelson <eric@nelint.com>
>>
>> I forgot to add an in-reply-to header.
>>
>> http://lists.denx.de/pipermail/u-boot/2015-December/thread.html#236651
>>
>>
>
> Fabio, I haven't been able to reproduce the "mmc erase/ENGcm03648"
> issue (with or without a code change) for a couple of hours now.
>
> Can you give this a spin?
>
> It seems unlikely to address the issue unless what we're seeing is a
> side effect of a glitch while switching clocks.
As Fabio, I can reproduce this 100% of the times.
The patch does not fix it, though.
--
Hector Palacios
next prev parent reply other threads:[~2015-12-04 18:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 17:32 [U-Boot] [PATCH] ARM: imx: fsl_esdhc: fix usage of low 4 bits of sysctl register Eric Nelson
2015-12-04 17:38 ` Eric Nelson
2015-12-04 17:43 ` Eric Nelson
2015-12-04 18:24 ` Fabio Estevam
2015-12-04 18:25 ` Hector Palacios [this message]
2015-12-04 18:33 ` Eric Nelson
2015-12-04 18:51 ` Hector Palacios
2015-12-04 19:24 ` Eric Nelson
2015-12-04 17:40 ` Michael Trimarchi
2015-12-04 17:49 ` Eric Nelson
2015-12-04 17:51 ` Michael Trimarchi
2015-12-04 18:39 ` Hector Palacios
2015-12-04 18:53 ` Eric Nelson
2015-12-04 19:32 ` [U-Boot] [PATCH V2] " Eric Nelson
2015-12-04 19:41 ` Fabio Estevam
2015-12-07 14:05 ` Stefano Babic
2015-12-09 10:04 ` Hector Palacios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5661DAAE.70106@digi.com \
--to=hector.palacios@digi.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox