public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric@nelint.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: imx: fsl_esdhc: fix usage of low 4 bits of sysctl register
Date: Fri, 4 Dec 2015 11:53:56 -0700	[thread overview]
Message-ID: <5661E144.7040604@nelint.com> (raw)
In-Reply-To: <5661DDDC.8030203@digi.com>

Thanks Hector,

On 12/04/2015 11:39 AM, Hector Palacios wrote:
> Hi,
> 
> On 12/04/2015 06:32 PM, Eric Nelson wrote:
>> The low four bits of the SYSCTL register are reserved on the USDHC
>> controller on i.MX6 and i.MX7 processors, but are used for clocking
>> operations on earlier models.
>>
>> Guard against their usage by hiding the bit mask macros on those
>> processors.
>>
...

>> diff --git a/include/fsl_esdhc.h b/include/fsl_esdhc.h
>> index aa1b4cf..a4b87ce 100644
>> --- a/include/fsl_esdhc.h
>> +++ b/include/fsl_esdhc.h
>> @@ -25,10 +25,12 @@
>>  #define SYSCTL_INITA		0x08000000
>>  #define SYSCTL_TIMEOUT_MASK	0x000f0000
>>  #define SYSCTL_CLOCK_MASK	0x0000fff0
>> +#if !defined(CONFIG_MX6)
> 
> Per your commit message should this be
> #if (!defined(CONFIG_MX6) && !defined(CONFIG_MX7))
> 

Good catch.

Will fix in a V2.

  reply	other threads:[~2015-12-04 18:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 17:32 [U-Boot] [PATCH] ARM: imx: fsl_esdhc: fix usage of low 4 bits of sysctl register Eric Nelson
2015-12-04 17:38 ` Eric Nelson
2015-12-04 17:43   ` Eric Nelson
2015-12-04 18:24     ` Fabio Estevam
2015-12-04 18:25     ` Hector Palacios
2015-12-04 18:33     ` Eric Nelson
2015-12-04 18:51       ` Hector Palacios
2015-12-04 19:24         ` Eric Nelson
2015-12-04 17:40 ` Michael Trimarchi
2015-12-04 17:49   ` Eric Nelson
2015-12-04 17:51     ` Michael Trimarchi
2015-12-04 18:39 ` Hector Palacios
2015-12-04 18:53   ` Eric Nelson [this message]
2015-12-04 19:32   ` [U-Boot] [PATCH V2] " Eric Nelson
2015-12-04 19:41     ` Fabio Estevam
2015-12-07 14:05     ` Stefano Babic
2015-12-09 10:04     ` Hector Palacios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5661E144.7040604@nelint.com \
    --to=eric@nelint.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox