public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check
Date: Fri, 4 Dec 2015 12:05:25 -0800	[thread overview]
Message-ID: <5661F205.6020502@freescale.com> (raw)
In-Reply-To: <1449177244-10120-1-git-send-email-stuart.yoder@freescale.com>

Prabhakar,

On 12/03/2015 01:14 PM, Stuart Yoder wrote:
> The MC version numbers provide no meaningful information
> about binary interface compatibility, so remove the
> check which refuses to start the MC unless a specific
> version is found.
> 
> Version checking is supposed to be done at the individual
> object level, and individual drivers are responsible
> for their own version checking.
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> ---
>  drivers/net/fsl-mc/mc.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
> index e1a02d1..bac4610 100644
> --- a/drivers/net/fsl-mc/mc.c
> +++ b/drivers/net/fsl-mc/mc.c
> @@ -541,19 +541,6 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr)
>  		goto out;
>  	}
>  
> -	if (MC_VER_MAJOR != mc_ver_info.major) {
> -		printf("fsl-mc: ERROR: Firmware major version mismatch (found: %d, expected: %d)\n",
> -		       mc_ver_info.major, MC_VER_MAJOR);
> -		printf("fsl-mc: Update the Management Complex firmware\n");
> -
> -		error = -ENODEV;
> -		goto out;
> -	}
> -
> -	if (MC_VER_MINOR != mc_ver_info.minor)
> -		printf("fsl-mc: WARNING: Firmware minor version mismatch (found: %d, expected: %d)\n",
> -		       mc_ver_info.minor, MC_VER_MINOR);
> -
>  	printf("fsl-mc: Management Complex booted (version: %d.%d.%d, boot status: %#x)\n",
>  	       mc_ver_info.major, mc_ver_info.minor, mc_ver_info.revision,
>  	       reg_gsr & GSR_FS_MASK);
> 

Are you OK with this change?

York

  reply	other threads:[~2015-12-04 20:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 21:14 [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check Stuart Yoder
2015-12-04 20:05 ` York Sun [this message]
2015-12-05  1:29   ` Kushwaha Prabhakar
2015-12-08 15:47   ` Kushwaha Prabhakar
2015-12-16  9:01 ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5661F205.6020502@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox