From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Fri, 4 Dec 2015 12:05:25 -0800 Subject: [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check In-Reply-To: <1449177244-10120-1-git-send-email-stuart.yoder@freescale.com> References: <1449177244-10120-1-git-send-email-stuart.yoder@freescale.com> Message-ID: <5661F205.6020502@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Prabhakar, On 12/03/2015 01:14 PM, Stuart Yoder wrote: > The MC version numbers provide no meaningful information > about binary interface compatibility, so remove the > check which refuses to start the MC unless a specific > version is found. > > Version checking is supposed to be done at the individual > object level, and individual drivers are responsible > for their own version checking. > > Signed-off-by: Stuart Yoder > --- > drivers/net/fsl-mc/mc.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c > index e1a02d1..bac4610 100644 > --- a/drivers/net/fsl-mc/mc.c > +++ b/drivers/net/fsl-mc/mc.c > @@ -541,19 +541,6 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr) > goto out; > } > > - if (MC_VER_MAJOR != mc_ver_info.major) { > - printf("fsl-mc: ERROR: Firmware major version mismatch (found: %d, expected: %d)\n", > - mc_ver_info.major, MC_VER_MAJOR); > - printf("fsl-mc: Update the Management Complex firmware\n"); > - > - error = -ENODEV; > - goto out; > - } > - > - if (MC_VER_MINOR != mc_ver_info.minor) > - printf("fsl-mc: WARNING: Firmware minor version mismatch (found: %d, expected: %d)\n", > - mc_ver_info.minor, MC_VER_MINOR); > - > printf("fsl-mc: Management Complex booted (version: %d.%d.%d, boot status: %#x)\n", > mc_ver_info.major, mc_ver_info.minor, mc_ver_info.revision, > reg_gsr & GSR_FS_MASK); > Are you OK with this change? York