* [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check
@ 2015-12-03 21:14 Stuart Yoder
2015-12-04 20:05 ` York Sun
2015-12-16 9:01 ` York Sun
0 siblings, 2 replies; 5+ messages in thread
From: Stuart Yoder @ 2015-12-03 21:14 UTC (permalink / raw)
To: u-boot
The MC version numbers provide no meaningful information
about binary interface compatibility, so remove the
check which refuses to start the MC unless a specific
version is found.
Version checking is supposed to be done at the individual
object level, and individual drivers are responsible
for their own version checking.
Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---
drivers/net/fsl-mc/mc.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
index e1a02d1..bac4610 100644
--- a/drivers/net/fsl-mc/mc.c
+++ b/drivers/net/fsl-mc/mc.c
@@ -541,19 +541,6 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr)
goto out;
}
- if (MC_VER_MAJOR != mc_ver_info.major) {
- printf("fsl-mc: ERROR: Firmware major version mismatch (found: %d, expected: %d)\n",
- mc_ver_info.major, MC_VER_MAJOR);
- printf("fsl-mc: Update the Management Complex firmware\n");
-
- error = -ENODEV;
- goto out;
- }
-
- if (MC_VER_MINOR != mc_ver_info.minor)
- printf("fsl-mc: WARNING: Firmware minor version mismatch (found: %d, expected: %d)\n",
- mc_ver_info.minor, MC_VER_MINOR);
-
printf("fsl-mc: Management Complex booted (version: %d.%d.%d, boot status: %#x)\n",
mc_ver_info.major, mc_ver_info.minor, mc_ver_info.revision,
reg_gsr & GSR_FS_MASK);
--
2.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check
2015-12-03 21:14 [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check Stuart Yoder
@ 2015-12-04 20:05 ` York Sun
2015-12-05 1:29 ` Kushwaha Prabhakar
2015-12-08 15:47 ` Kushwaha Prabhakar
2015-12-16 9:01 ` York Sun
1 sibling, 2 replies; 5+ messages in thread
From: York Sun @ 2015-12-04 20:05 UTC (permalink / raw)
To: u-boot
Prabhakar,
On 12/03/2015 01:14 PM, Stuart Yoder wrote:
> The MC version numbers provide no meaningful information
> about binary interface compatibility, so remove the
> check which refuses to start the MC unless a specific
> version is found.
>
> Version checking is supposed to be done at the individual
> object level, and individual drivers are responsible
> for their own version checking.
>
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> ---
> drivers/net/fsl-mc/mc.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
> index e1a02d1..bac4610 100644
> --- a/drivers/net/fsl-mc/mc.c
> +++ b/drivers/net/fsl-mc/mc.c
> @@ -541,19 +541,6 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr)
> goto out;
> }
>
> - if (MC_VER_MAJOR != mc_ver_info.major) {
> - printf("fsl-mc: ERROR: Firmware major version mismatch (found: %d, expected: %d)\n",
> - mc_ver_info.major, MC_VER_MAJOR);
> - printf("fsl-mc: Update the Management Complex firmware\n");
> -
> - error = -ENODEV;
> - goto out;
> - }
> -
> - if (MC_VER_MINOR != mc_ver_info.minor)
> - printf("fsl-mc: WARNING: Firmware minor version mismatch (found: %d, expected: %d)\n",
> - mc_ver_info.minor, MC_VER_MINOR);
> -
> printf("fsl-mc: Management Complex booted (version: %d.%d.%d, boot status: %#x)\n",
> mc_ver_info.major, mc_ver_info.minor, mc_ver_info.revision,
> reg_gsr & GSR_FS_MASK);
>
Are you OK with this change?
York
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check
2015-12-04 20:05 ` York Sun
@ 2015-12-05 1:29 ` Kushwaha Prabhakar
2015-12-08 15:47 ` Kushwaha Prabhakar
1 sibling, 0 replies; 5+ messages in thread
From: Kushwaha Prabhakar @ 2015-12-05 1:29 UTC (permalink / raw)
To: u-boot
HI Stuart
> -----Original Message-----
> From: York Sun [mailto:yorksun at freescale.com]
> Sent: Saturday, December 05, 2015 1:35 AM
> To: Yoder Stuart-B08248 <stuart.yoder@freescale.com>; Kushwaha
> Prabhakar-B32579 <prabhakar@freescale.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [PATCH] driver: net: fsl-mc: remove MC firmware version check
>
> Prabhakar,
>
> On 12/03/2015 01:14 PM, Stuart Yoder wrote:
> > The MC version numbers provide no meaningful information about binary
> > interface compatibility, so remove the check which refuses to start
> > the MC unless a specific version is found.
> >
> > Version checking is supposed to be done at the individual object
> > level, and individual drivers are responsible for their own version
> > checking.
> >
> > Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> > ---
> > drivers/net/fsl-mc/mc.c | 13 -------------
> > 1 file changed, 13 deletions(-)
> >
> > diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c index
> > e1a02d1..bac4610 100644
> > --- a/drivers/net/fsl-mc/mc.c
> > +++ b/drivers/net/fsl-mc/mc.c
> > @@ -541,19 +541,6 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr)
> > goto out;
> > }
> >
> > - if (MC_VER_MAJOR != mc_ver_info.major) {
> > - printf("fsl-mc: ERROR: Firmware major version mismatch
> (found: %d, expected: %d)\n",
> > - mc_ver_info.major, MC_VER_MAJOR);
> > - printf("fsl-mc: Update the Management Complex
> firmware\n");
> > -
> > - error = -ENODEV;
> > - goto out;
> > - }
> > -
> > - if (MC_VER_MINOR != mc_ver_info.minor)
> > - printf("fsl-mc: WARNING: Firmware minor version mismatch
> (found: %d, expected: %d)\n",
> > - mc_ver_info.minor, MC_VER_MINOR);
> > -
> > printf("fsl-mc: Management Complex booted (version: %d.%d.%d,
> boot status: %#x)\n",
> > mc_ver_info.major, mc_ver_info.minor, mc_ver_info.revision,
> > reg_gsr & GSR_FS_MASK);
> >
>
> Are you OK with this change?
As per my understanding, version of individual components are fix in a major MC release.
Are you saying, there is possibility of object version change in a minor MC release?
--Prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check
2015-12-04 20:05 ` York Sun
2015-12-05 1:29 ` Kushwaha Prabhakar
@ 2015-12-08 15:47 ` Kushwaha Prabhakar
1 sibling, 0 replies; 5+ messages in thread
From: Kushwaha Prabhakar @ 2015-12-08 15:47 UTC (permalink / raw)
To: u-boot
Hi York,
> -----Original Message-----
> From: York Sun [mailto:yorksun at freescale.com]
> Sent: Saturday, December 05, 2015 1:35 AM
> To: Yoder Stuart-B08248 <stuart.yoder@freescale.com>; Kushwaha
> Prabhakar-B32579 <prabhakar@freescale.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [PATCH] driver: net: fsl-mc: remove MC firmware version check
>
> Prabhakar,
>
> On 12/03/2015 01:14 PM, Stuart Yoder wrote:
> > The MC version numbers provide no meaningful information about binary
> > interface compatibility, so remove the check which refuses to start
> > the MC unless a specific version is found.
> >
> > Version checking is supposed to be done at the individual object
> > level, and individual drivers are responsible for their own version
> > checking.
> >
> > Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> > ---
> > drivers/net/fsl-mc/mc.c | 13 -------------
> > 1 file changed, 13 deletions(-)
> >
> > diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c index
> > e1a02d1..bac4610 100644
> > --- a/drivers/net/fsl-mc/mc.c
> > +++ b/drivers/net/fsl-mc/mc.c
> > @@ -541,19 +541,6 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr)
> > goto out;
> > }
> >
> > - if (MC_VER_MAJOR != mc_ver_info.major) {
> > - printf("fsl-mc: ERROR: Firmware major version mismatch
> (found: %d, expected: %d)\n",
> > - mc_ver_info.major, MC_VER_MAJOR);
> > - printf("fsl-mc: Update the Management Complex
> firmware\n");
> > -
> > - error = -ENODEV;
> > - goto out;
> > - }
> > -
> > - if (MC_VER_MINOR != mc_ver_info.minor)
> > - printf("fsl-mc: WARNING: Firmware minor version mismatch
> (found: %d, expected: %d)\n",
> > - mc_ver_info.minor, MC_VER_MINOR);
> > -
> > printf("fsl-mc: Management Complex booted (version: %d.%d.%d,
> boot status: %#x)\n",
> > mc_ver_info.major, mc_ver_info.minor, mc_ver_info.revision,
> > reg_gsr & GSR_FS_MASK);
> >
>
> Are you OK with this change?
I had a discussion with Stuart and got answer of all my concern.
I am OK with this patch.
--prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check
2015-12-03 21:14 [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check Stuart Yoder
2015-12-04 20:05 ` York Sun
@ 2015-12-16 9:01 ` York Sun
1 sibling, 0 replies; 5+ messages in thread
From: York Sun @ 2015-12-16 9:01 UTC (permalink / raw)
To: u-boot
On 12/04/2015 05:14 AM, Stuart Yoder wrote:
> The MC version numbers provide no meaningful information
> about binary interface compatibility, so remove the
> check which refuses to start the MC unless a specific
> version is found.
>
> Version checking is supposed to be done at the individual
> object level, and individual drivers are responsible
> for their own version checking.
>
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> ---
> drivers/net/fsl-mc/mc.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
Applied to u-boot-fsl-qoriq master. Awaiting upstream.
York
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-16 9:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-03 21:14 [U-Boot] [PATCH] driver: net: fsl-mc: remove MC firmware version check Stuart Yoder
2015-12-04 20:05 ` York Sun
2015-12-05 1:29 ` Kushwaha Prabhakar
2015-12-08 15:47 ` Kushwaha Prabhakar
2015-12-16 9:01 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox