public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx6sxsabresd: Fix Ethernet PHY reset sequence
Date: Mon, 7 Dec 2015 14:49:51 +0100	[thread overview]
Message-ID: <56658E7F.9080401@denx.de> (raw)
In-Reply-To: <CAOMZO5B8K_2c3ZXJbMcH1QpEaZNdp9=yjaK3J2P7f8vWGc19WQ@mail.gmail.com>

On 04/12/2015 14:13, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Mon, Nov 23, 2015 at 4:18 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Since commit 59370f3fcd1350 ("net: phy: delay only if reset handler is
>> registered") Ethernet is no longer functional.
>>
>> This commit does not have an issue in itself, but it revelead a problem
>> with the Ethernet initialization.
>>
>> Fix this by calling enable_fec_anatop_clock() earlier and also
>> by adding a 10ms reset delay as recommended in the AR8031 datasheet.
>>
>> Suggested-by: J?rg Krause <joerg.krause@embedded.rocks>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Any comments about this one?
> 
> Regards,
> 
> Fabio Estevam
> 

Fine with me, and I have not seen any other comments. I am applying it.

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      reply	other threads:[~2015-12-07 13:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 18:18 [U-Boot] [PATCH v2] mx6sxsabresd: Fix Ethernet PHY reset sequence Fabio Estevam
2015-12-04 13:13 ` Fabio Estevam
2015-12-07 13:49   ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56658E7F.9080401@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox