public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] ns16550: change reg-shift property default to zero
Date: Mon, 7 Dec 2015 10:32:29 -0700	[thread overview]
Message-ID: <5665C2AD.1020503@wwwdotorg.org> (raw)
In-Reply-To: <20151206220729.GS9551@bill-the-cat>

On 12/06/2015 03:07 PM, Tom Rini wrote:
> On Sun, Nov 29, 2015 at 02:01:03PM +0800, Thomas Chou wrote:
>
>> Change reg-shift property default to zero. When the integer property
>> is missing, it should be taken as zero. This is consistent to Linux
>> drivers/tty/serial/of_serial.c.

It's not generally true that missing properties have value zero. Rather, 
whatever values was assumed by the semantics of the binding before that 
optional property was defined should be assumed.

What the Linux kernel driver does also isn't justification for this 
change, since DT bindings define how they work, rather than a particular 
OS implementation forcing the hand of the binding.

The DT binding documentation must state the default value/semantics for 
any optional property. Can you please make sure the DT binding 
documentation is updated to describe this case?

(Note that I have no objection to this patch; the actual change seems 
fine. It's simply that the justifications given in the patch description 
for it aren't entirely robust.)

  reply	other threads:[~2015-12-07 17:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-29  6:01 [U-Boot] [PATCH] ns16550: change reg-shift property default to zero Thomas Chou
2015-11-29  8:51 ` Bin Meng
2015-11-30  6:07 ` Mugunthan V N
2015-11-30 23:17   ` Simon Glass
2015-12-06 22:07 ` [U-Boot] " Tom Rini
2015-12-07 17:32   ` Stephen Warren [this message]
2015-12-08  0:18     ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665C2AD.1020503@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox