public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Philippe De Swert <philippedeswert@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mkimage: Fix generating multi and script images again
Date: Mon, 07 Dec 2015 22:52:58 +0200	[thread overview]
Message-ID: <5665F1AA.8080407@gmail.com> (raw)
In-Reply-To: <20151207190626.GP9551@bill-the-cat>

Hi,

On 07/12/15 21:06, Tom Rini wrote:
> On Mon, Dec 07, 2015 at 06:01:54PM +0100, Marek Vasut wrote:
>
>> Seems 6ae6e160 broke creating multi and script type images and even
>> building of mkimage itself. There are two problems with that patch.
>>
>> First is that expression (!(x == 0) || !(x == 1)) is always true for
>> unsigned int x. The expression must use AND (&&) not OR (||) to be
>> correct.
>>
>> After rewording the commit message a bit (and talking with Marek on IRC
>> about my reword), applied to u-boot/master, thanks!
>>

Great! Apologies for the breakage,

Philippe

      reply	other threads:[~2015-12-07 20:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 17:01 [U-Boot] [PATCH] mkimage: Fix generating multi and script images again Marek Vasut
2015-12-07 17:18 ` Philippe De Swert
2015-12-07 17:32   ` Marek Vasut
2015-12-07 17:47 ` Wolfgang Denk
2015-12-07 18:03   ` Tom Rini
2015-12-07 18:05   ` Marek Vasut
2015-12-07 19:06 ` Tom Rini
2015-12-07 20:52   ` Philippe De Swert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665F1AA.8080407@gmail.com \
    --to=philippedeswert@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox