From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe De Swert Date: Mon, 07 Dec 2015 22:52:58 +0200 Subject: [U-Boot] [PATCH] mkimage: Fix generating multi and script images again In-Reply-To: <20151207190626.GP9551@bill-the-cat> References: <1449507714-9599-1-git-send-email-marex@denx.de> <20151207190626.GP9551@bill-the-cat> Message-ID: <5665F1AA.8080407@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 07/12/15 21:06, Tom Rini wrote: > On Mon, Dec 07, 2015 at 06:01:54PM +0100, Marek Vasut wrote: > >> Seems 6ae6e160 broke creating multi and script type images and even >> building of mkimage itself. There are two problems with that patch. >> >> First is that expression (!(x == 0) || !(x == 1)) is always true for >> unsigned int x. The expression must use AND (&&) not OR (||) to be >> correct. >> >> After rewording the commit message a bit (and talking with Marek on IRC >> about my reword), applied to u-boot/master, thanks! >> Great! Apologies for the breakage, Philippe