[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[Michal Simek]

Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid
pointer from integer cast size mismatch warnings.

Warning log:
+../drivers/usb/gadget/udc/udc-core.c: In function
?usb_gadget_unmap_request?:
+../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer
from integer of different size [-Wint-to-pointer-cast]

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/usb/gadget/udc/udc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c
index 875e998a82e3..326757b547fa 100644
--- a/drivers/usb/gadget/udc/udc-core.c
+++ b/drivers/usb/gadget/udc/udc-core.c
@@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget *gadget,
 	if (req->length == 0)
 		return;
 
-	dma_unmap_single((void *)req->dma, req->length,
+	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
 			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
 }
 EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
-- 
2.5.0

[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[Lukasz Majewski]

Hi Michal,

> Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid
> pointer from integer cast size mismatch warnings.
> 
> Warning log:
> +../drivers/usb/gadget/udc/udc-core.c: In function
> ?usb_gadget_unmap_request?:
> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer
> from integer of different size [-Wint-to-pointer-cast]
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/usb/gadget/udc/udc-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/udc-core.c
> b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa
> 100644 --- a/drivers/usb/gadget/udc/udc-core.c
> +++ b/drivers/usb/gadget/udc/udc-core.c
> @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget
> *gadget, if (req->length == 0)
>  		return;
>  
> -	dma_unmap_single((void *)req->dma, req->length,
> +	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
>  			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
>  }
>  EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);

Acked-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[Michal Simek]

Hi Marek and Lukasz,

On 3.11.2015 11:14, Lukasz Majewski wrote:
> Hi Michal,
> 
>> Cast u32 bit value to 64bit before recasting to 64bit pointer to avoid
>> pointer from integer cast size mismatch warnings.
>>
>> Warning log:
>> +../drivers/usb/gadget/udc/udc-core.c: In function
>> ?usb_gadget_unmap_request?:
>> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to pointer
>> from integer of different size [-Wint-to-pointer-cast]
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  drivers/usb/gadget/udc/udc-core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/udc/udc-core.c
>> b/drivers/usb/gadget/udc/udc-core.c index 875e998a82e3..326757b547fa
>> 100644 --- a/drivers/usb/gadget/udc/udc-core.c
>> +++ b/drivers/usb/gadget/udc/udc-core.c
>> @@ -65,7 +65,7 @@ void usb_gadget_unmap_request(struct usb_gadget
>> *gadget, if (req->length == 0)
>>  		return;
>>  
>> -	dma_unmap_single((void *)req->dma, req->length,
>> +	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
>>  			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
>>  }
>>  EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
> 
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> 

Is this patch in any of your queue?

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151207/e0e1431b/attachment.sig>

[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[Lukasz Majewski]

Hi Michal,

> Hi Marek and Lukasz,
> 
> On 3.11.2015 11:14, Lukasz Majewski wrote:
> > Hi Michal,
> > 
> >> Cast u32 bit value to 64bit before recasting to 64bit pointer to
> >> avoid pointer from integer cast size mismatch warnings.
> >>
> >> Warning log:
> >> +../drivers/usb/gadget/udc/udc-core.c: In function
> >> ?usb_gadget_unmap_request?:
> >> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
> >> pointer from integer of different size [-Wint-to-pointer-cast]
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >>  drivers/usb/gadget/udc/udc-core.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/gadget/udc/udc-core.c
> >> b/drivers/usb/gadget/udc/udc-core.c index
> >> 875e998a82e3..326757b547fa 100644 ---
> >> a/drivers/usb/gadget/udc/udc-core.c +++
> >> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
> >> usb_gadget_unmap_request(struct usb_gadget *gadget, if
> >> (req->length == 0) return;
> >>  
> >> -	dma_unmap_single((void *)req->dma, req->length,
> >> +	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
> >>  			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
> >>  }
> >>  EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
> > 
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> > 
> 
> Is this patch in any of your queue?
> 
> Thanks,
> Michal
> 

I can grab this to -dfu tree since I'm in the middle of preparing PR.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[Michal Simek]

On 8.12.2015 07:59, Lukasz Majewski wrote:
> Hi Michal,
> 
>> Hi Marek and Lukasz,
>>
>> On 3.11.2015 11:14, Lukasz Majewski wrote:
>>> Hi Michal,
>>>
>>>> Cast u32 bit value to 64bit before recasting to 64bit pointer to
>>>> avoid pointer from integer cast size mismatch warnings.
>>>>
>>>> Warning log:
>>>> +../drivers/usb/gadget/udc/udc-core.c: In function
>>>> ?usb_gadget_unmap_request?:
>>>> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
>>>> pointer from integer of different size [-Wint-to-pointer-cast]
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>>  drivers/usb/gadget/udc/udc-core.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/usb/gadget/udc/udc-core.c
>>>> b/drivers/usb/gadget/udc/udc-core.c index
>>>> 875e998a82e3..326757b547fa 100644 ---
>>>> a/drivers/usb/gadget/udc/udc-core.c +++
>>>> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
>>>> usb_gadget_unmap_request(struct usb_gadget *gadget, if
>>>> (req->length == 0) return;
>>>>  
>>>> -	dma_unmap_single((void *)req->dma, req->length,
>>>> +	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
>>>>  			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
>>>>  }
>>>>  EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
>>>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>
>>
>> Is this patch in any of your queue?
>>
>> Thanks,
>> Michal
>>
> 
> I can grab this to -dfu tree since I'm in the middle of preparing PR.
> 

Thanks,
Michal

[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[Lukasz Majewski]

Hi Michal,

> Hi Marek and Lukasz,
> 
> On 3.11.2015 11:14, Lukasz Majewski wrote:
> > Hi Michal,
> > 
> >> Cast u32 bit value to 64bit before recasting to 64bit pointer to
> >> avoid pointer from integer cast size mismatch warnings.
> >>
> >> Warning log:
> >> +../drivers/usb/gadget/udc/udc-core.c: In function
> >> ?usb_gadget_unmap_request?:
> >> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
> >> pointer from integer of different size [-Wint-to-pointer-cast]
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >>  drivers/usb/gadget/udc/udc-core.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/gadget/udc/udc-core.c
> >> b/drivers/usb/gadget/udc/udc-core.c index
> >> 875e998a82e3..326757b547fa 100644 ---
> >> a/drivers/usb/gadget/udc/udc-core.c +++
> >> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
> >> usb_gadget_unmap_request(struct usb_gadget *gadget, if
> >> (req->length == 0) return;
> >>  
> >> -	dma_unmap_single((void *)req->dma, req->length,
> >> +	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
> >>  			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
> >>  }
> >>  EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
> > 
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> > 
> 
> Is this patch in any of your queue?

It is already applied to -usb tree :-).

> 
> Thanks,
> Michal
> 



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [PATCH] usb: udc: Fix warnings on 64-bit builds

[Michal Simek]

On 9.12.2015 10:33, Lukasz Majewski wrote:
> Hi Michal,
> 
>> Hi Marek and Lukasz,
>>
>> On 3.11.2015 11:14, Lukasz Majewski wrote:
>>> Hi Michal,
>>>
>>>> Cast u32 bit value to 64bit before recasting to 64bit pointer to
>>>> avoid pointer from integer cast size mismatch warnings.
>>>>
>>>> Warning log:
>>>> +../drivers/usb/gadget/udc/udc-core.c: In function
>>>> ?usb_gadget_unmap_request?:
>>>> +../drivers/usb/gadget/udc/udc-core.c:68:19: warning: cast to
>>>> pointer from integer of different size [-Wint-to-pointer-cast]
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>>  drivers/usb/gadget/udc/udc-core.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/usb/gadget/udc/udc-core.c
>>>> b/drivers/usb/gadget/udc/udc-core.c index
>>>> 875e998a82e3..326757b547fa 100644 ---
>>>> a/drivers/usb/gadget/udc/udc-core.c +++
>>>> b/drivers/usb/gadget/udc/udc-core.c @@ -65,7 +65,7 @@ void
>>>> usb_gadget_unmap_request(struct usb_gadget *gadget, if
>>>> (req->length == 0) return;
>>>>  
>>>> -	dma_unmap_single((void *)req->dma, req->length,
>>>> +	dma_unmap_single((void *)(uintptr_t)req->dma, req->length,
>>>>  			 is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
>>>>  }
>>>>  EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);
>>>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>
>>
>> Is this patch in any of your queue?
> 
> It is already applied to -usb tree :-).

Then great.

Thanks,
Michal