[U-Boot] [PATCH 0/3] ARM: at91: add PMC_PLLICPR init function

[Heiko Schocher <hs@denx.de>]

Hello Wenyou,

Am 09.12.2015 um 05:36 schrieb Wenyou Yang:
> To reduce the duplicated code, add PLLICPR init function, use
> the function to clean up the PMC_PLLICPR directly writing code.
>
> It is based on the following patch set.
> 	[PATCH 0/5] ARM: at91: improve peripheral and system clock handle functions
> 	[PATCH 0/4] ARM: at91: add UTMI PLL handle functions
> 	[PATCH 0/3] ARM: at91: add PLLB handle functions
>
>
> Wenyou Yang (3):
>    ARM: at91: clock: add PMC_PLLICPR init function
>    ARM: at91: clean up the PMC_PLLICPR init code
>    board: atmel: clean up the PMC_PLLICPR init code
>
>   arch/arm/mach-at91/armv7/clock.c                |    7 +++++++
>   arch/arm/mach-at91/include/mach/at91_pmc.h      |    7 +++++++
>   arch/arm/mach-at91/include/mach/clk.h           |    1 +
>   arch/arm/mach-at91/spl_at91.c                   |    5 +----
>   board/atmel/sama5d3_xplained/sama5d3_xplained.c |    4 +---
>   board/atmel/sama5d3xek/sama5d3xek.c             |    4 +---
>   board/atmel/sama5d4_xplained/sama5d4_xplained.c |    4 +---
>   board/atmel/sama5d4ek/sama5d4ek.c               |    4 +---
>   8 files changed, 20 insertions(+), 16 deletions(-)

I applied all your at91 patches from:

  It is based on the following patch set.
  	[PATCH 0/5] ARM: at91: improve peripheral and system clock handle functions
  	[PATCH 0/4] ARM: at91: add UTMI PLL handle functions
  	[PATCH 0/3] ARM: at91: add PLLB handle functions

also this series, and compiled it for the smartweb board. This build fails:

   LD      spl/u-boot-spl
arch/arm/mach-at91/built-in.o: In function `board_init_f':
/home/hs/zug/u-boot/arch/arm/mach-at91/spl_at91.c:86: undefined reference to `at91_pllicpr_init'
/home/hs/zug/u-boot/scripts/Makefile.spl:244: recipe for target 'spl/u-boot-spl' failed
make[2]: *** [spl/u-boot-spl] Error 1
/home/hs/zug/u-boot/Makefile:1330: recipe for target 'spl/u-boot-spl' failed
make[1]: *** [spl/u-boot-spl] Error 2
make[1]: Leaving directory '/work/hs/compile/u-boot/zug/smartweb'
Makefile:150: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
make failed
pollux:u-boot hs [20151209] $

Please do a build for all at91 boards, before posting your patches
again. Also try to have a look at the codesize ... the smartweb
board have only 4k for the SPL image...

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany