public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] ARM: at91: clean up the PMC_PLLICPR init code
Date: Thu, 10 Dec 2015 10:35:35 +0100	[thread overview]
Message-ID: <56694767.3040606@denx.de> (raw)
In-Reply-To: <1449646720-30057-3-git-send-email-wenyou.yang@atmel.com>

Hello Wenyou,

Am 09.12.2015 um 08:38 schrieb Wenyou Yang:
> Due to introducing the PMC_PLLICPR init function, use this
> function to clean up the code.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> Changes in v2: None
>
>   arch/arm/mach-at91/spl_at91.c |    5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Tested on the smartweb board, see log:
http://xeidos.ddns.net/buildbot/builders/smartweb_dfu/builds/29/steps/shell/logs/tbotlog

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/arch/arm/mach-at91/spl_at91.c b/arch/arm/mach-at91/spl_at91.c
> index b19f95b..cc3341a 100644
> --- a/arch/arm/mach-at91/spl_at91.c
> +++ b/arch/arm/mach-at91/spl_at91.c
> @@ -14,7 +14,6 @@
>   #include <asm/arch/at91_common.h>
>   #include <asm/arch/at91sam9_matrix.h>
>   #include <asm/arch/at91_pit.h>
> -#include <asm/arch/at91_pmc.h>
>   #include <asm/arch/at91_rstc.h>
>   #include <asm/arch/at91_wdt.h>
>   #include <asm/arch/clk.h>
> @@ -77,8 +76,6 @@ void __weak spl_board_init(void)
>
>   void board_init_f(ulong dummy)
>   {
> -	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> -
>   	lowlevel_clock_init();
>   	at91_disable_wdt();
>
> @@ -86,7 +83,7 @@ void board_init_f(ulong dummy)
>   	 * At this stage the main oscillator is supposed to be enabled
>   	 * PCK = MCK = MOSC
>   	 */
> -	writel(0x00, &pmc->pllicpr);
> +	at91_pllicpr_init(0x00);
>
>   	/* Configure PLLA = MOSC * (PLL_MULA + 1) / PLL_DIVA */
>   	at91_plla_init(CONFIG_SYS_AT91_PLLA);
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2015-12-10  9:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  7:38 [U-Boot] [PATCH v2 0/3] ARM: at91: add PMC_PLLICPR init function Wenyou Yang
2015-12-09  7:38 ` [U-Boot] [PATCH v2 1/3] ARM: at91: clock: " Wenyou Yang
2015-12-10  9:35   ` Heiko Schocher
2015-12-09  7:38 ` [U-Boot] [PATCH v2 2/3] ARM: at91: clean up the PMC_PLLICPR init code Wenyou Yang
2015-12-10  9:35   ` Heiko Schocher [this message]
2015-12-09  7:38 ` [U-Boot] [PATCH v2 3/3] board: atmel: " Wenyou Yang
2015-12-10  9:35   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56694767.3040606@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox