public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ns16550: update compatible and reg-shift binding
Date: Fri, 11 Dec 2015 15:08:47 +0800	[thread overview]
Message-ID: <566A767F.2080100@wytron.com.tw> (raw)
In-Reply-To: <566A60B5.5000201@wwwdotorg.org>

Hi Stephen,

On 2015?12?11? 13:35, Stephen Warren wrote:
> On 12/10/2015 10:08 PM, Thomas Chou wrote:
>> Update compatible and reg-shift in device tree binding.
>
> Has this change been submitted to and accepted by the Linux kernel?
> That's where the official DT binding documents are stored. Honestly I
> think we should remove the copies in U-Boot to avoid confusion and forking.
>
> The content of the change looks reasonable at a quick glance.
>

These changes actually came from Linux kernel. They are scattered in 
several files. I included only those are prevalent to u-boot.

8250.txt
- compatible : one of:
	- "ns8250"
	- "ns16450"
	- "ns16550a"
	- "ns16550"
	- "ns16750"
	- "ns16850"
	- For Tegra20, must contain "nvidia,tegra20-uart"
	- For other Tegra, must contain '"nvidia,<chip>-uart",
	  "nvidia,tegra20-uart"' where <chip> is tegra30, tegra114, tegra124,
	  tegra132, or tegra210.

omap_serial.txt
- compatible : should be "ti,omap2-uart" for OMAP2 controllers
- compatible : should be "ti,omap3-uart" for OMAP3 controllers
- compatible : should be "ti,omap4-uart" for OMAP4 controllers
- compatible : should be "ti,am4372-uart" for AM437x controllers
- compatible : should be "ti,am3352-uart" for AM335x controllers
- compatible : should be "ti,dra742-uart" for DRA7x controllers

snps-dw-apb-uart.txt
- compatible : "snps,dw-apb-uart"
- reg-shift : quantity to shift the register offsets by.  If this 
property is not present then the register offsets are not shifted.

I can change the description reg-shift property to above if this make it 
clearer.

I would agree that we can remove these copies of Linux kernel. Almost 
every dts binding I added to u-boot these months are copied from Linux 
kernel.

Best regards,
Thomas

  reply	other threads:[~2015-12-11  7:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  5:08 [U-Boot] [PATCH 1/2] ns16550: update compatible and reg-shift binding Thomas Chou
2015-12-11  5:08 ` [U-Boot] [PATCH 2/2] ns16550: zap the rockchip serial compatible string Thomas Chou
2015-12-19  2:51   ` Simon Glass
2015-12-11  5:35 ` [U-Boot] [PATCH 1/2] ns16550: update compatible and reg-shift binding Stephen Warren
2015-12-11  7:08   ` Thomas Chou [this message]
2015-12-11 15:42     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566A767F.2080100@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox