From: Eric Nelson <eric@nelint.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] imx_common: check for Serial Downloader in spl_boot_device
Date: Fri, 11 Dec 2015 12:49:13 -0700 [thread overview]
Message-ID: <566B28B9.7050402@nelint.com> (raw)
In-Reply-To: <201512111833.17200.marex@denx.de>
On 12/11/2015 10:33 AM, Marek Vasut wrote:
> On Friday, December 11, 2015 at 03:58:35 PM, Stefano Babic wrote:
>> Hi Eric,
>>
>> On 11/12/2015 15:40, Eric Nelson wrote:
...
>>>> + /*
>>>> + * Check for BMODE if serial downloader is enabled
>>>> + * BOOT_MODE - see IMX6DQRM Table 8-1
>>>> + */
>>>> + if ((((bmode >> 24) & 0x03) == 0x01) || /* Serial Downloader */
>>>
>>> I think Marek will have a problem with the yoda conditional:
>>>> + (gpr10_boot && (1 == reg)))
>>
>> I fix it in V3 before Marek complains :-). I do not like yoda
>> conditions, too.
>
> Problem, I have ;-)
>
Even this week?
You guys have never had the compiler catch an erroneous assignment
like this one:
if (i = 1)
...
I got in this habit many years ago after reading "Code Complete",
and it's saved me many a time...
I need to figure out how to get checkpatch.pl to watch it for me
when pushing stuff up-stream.
next prev parent reply other threads:[~2015-12-11 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 13:40 [U-Boot] [PATCH v2] imx_common: check for Serial Downloader in spl_boot_device Stefano Babic
2015-12-11 14:40 ` Eric Nelson
2015-12-11 14:58 ` Stefano Babic
2015-12-11 17:33 ` Marek Vasut
2015-12-11 19:49 ` Eric Nelson [this message]
2015-12-11 20:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566B28B9.7050402@nelint.com \
--to=eric@nelint.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox