From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric@nelint.com>
Date: Fri, 11 Dec 2015 12:49:13 -0700
Subject: [U-Boot] [PATCH v2] imx_common: check for Serial Downloader in
 spl_boot_device
In-Reply-To: <201512111833.17200.marex@denx.de>
References: <1449841219-22857-1-git-send-email-sbabic@denx.de>
 <566AE06D.9000102@nelint.com> <566AE49B.7020804@denx.de>
 <201512111833.17200.marex@denx.de>
Message-ID: <566B28B9.7050402@nelint.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/11/2015 10:33 AM, Marek Vasut wrote:
> On Friday, December 11, 2015 at 03:58:35 PM, Stefano Babic wrote:
>> Hi Eric,
>>
>> On 11/12/2015 15:40, Eric Nelson wrote:
...
>>>> +	/*
>>>> +	 * Check for BMODE if serial downloader is enabled
>>>> +	 * BOOT_MODE - see IMX6DQRM Table 8-1
>>>> +	 */
>>>> +	if ((((bmode >> 24) & 0x03)  == 0x01) || /* Serial Downloader */
>>>
>>> I think Marek will have a problem with the yoda conditional:
>>>> +		(gpr10_boot && (1 == reg)))
>>
>> I fix it in V3 before Marek complains :-). I do not like yoda
>> conditions, too.
> 
> Problem, I have ;-)
> 

Even this week?

You guys have never had the compiler catch an erroneous assignment
like this one:

	if (i = 1)
		...

I got in this habit many years ago after reading "Code Complete",
and it's saved me many a time...

I need to figure out how to get checkpatch.pl to watch it for me
when pushing stuff up-stream.