public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] serial: uartlite: Add uartlite to Kconfig
Date: Mon, 14 Dec 2015 16:42:09 +0100	[thread overview]
Message-ID: <566EE351.8070808@xilinx.com> (raw)
In-Reply-To: <566ED3B2.5000202@wytron.com.tw>

On 14.12.2015 15:35, Thomas Chou wrote:
> Hi Michal,
> 
> On 2015?12?11? 19:54, Michal Simek wrote:
>> - Move config option out of board file.
>> - Remove uartlite address from config file
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>   board/xilinx/microblaze-generic/xparameters.h | 4 ----
>>   configs/microblaze-generic_defconfig          | 1 +
>>   drivers/serial/Kconfig                        | 7 +++++++
>>   include/configs/microblaze-generic.h          | 7 +------
>>   4 files changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/board/xilinx/microblaze-generic/xparameters.h
>> b/board/xilinx/microblaze-generic/xparameters.h
>> index 8ba146cb88db..11b3c9a4846e 100644
>> --- a/board/xilinx/microblaze-generic/xparameters.h
>> +++ b/board/xilinx/microblaze-generic/xparameters.h
>> @@ -28,10 +28,6 @@
>>   #define XILINX_TIMER_BASEADDR    0x41c00000
>>   #define XILINX_TIMER_IRQ    0
>>
>> -/* Uart pheriphery is RS232_Uart */
>> -#define XILINX_UARTLITE_BASEADDR    0x40600000
>> -#define XILINX_UARTLITE_BAUDRATE    115200
>> -
>>   /* IIC pheriphery is IIC_EEPROM */
>>   #define XILINX_IIC_0_BASEADDR    0x40800000
>>   #define XILINX_IIC_0_FREQ    100000
>> diff --git a/configs/microblaze-generic_defconfig
>> b/configs/microblaze-generic_defconfig
>> index 5df080b6a87c..9a7bb915466f 100644
>> --- a/configs/microblaze-generic_defconfig
>> +++ b/configs/microblaze-generic_defconfig
>> @@ -9,3 +9,4 @@ CONFIG_CMD_GPIO=y
>>   # CONFIG_CMD_SETEXPR is not set
>>   CONFIG_SPL_OF_CONTROL=y
>>   CONFIG_OF_EMBED=y
>> +CONFIG_XILINX_UARTLITE=y
>> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
>> index f1e221799b81..ddf49ba9cef3 100644
>> --- a/drivers/serial/Kconfig
>> +++ b/drivers/serial/Kconfig
>> @@ -230,4 +230,11 @@ config UNIPHIER_SERIAL
>>         If you have a UniPhier based board and want to use the on-chip
>>         serial ports, say Y to this option. If unsure, say N.
>>
>> +config XILINX_UARTLITE
>> +    bool "Xilinx Uarlite support"
>> +    depends on DM_SERIAL && (MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP)
>> +    help
>> +      If you have a Xilinx based board and want to use the uartlite
>> +      serial ports, say Y to this option. If unsure, say N.
>> +
>>   endmenu
> 
> Kconfig should be with the driver 1/3. Others are boards related.

It can be. Adding Kconfig fragment can be separate patch out of move to
DM. There is no connection too.
My intention was to show all related changes which are done by this one
step.

Thanks,
Michal

  reply	other threads:[~2015-12-14 15:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 11:54 [U-Boot] [PATCH 0/3] Moving Uartlite to DM Michal Simek
2015-12-11 11:54 ` [U-Boot] [PATCH 1/3] serial: uartlite: Move driver " Michal Simek
2015-12-14 14:47   ` Thomas Chou
2015-12-14 16:03     ` Michal Simek
2015-12-11 11:54 ` [U-Boot] [PATCH 2/3] serial: uartlite: Add support for debug console Michal Simek
2015-12-14 13:14   ` Thomas Chou
2015-12-14 15:50     ` Michal Simek
2015-12-15  4:01       ` Thomas Chou
2015-12-15 15:38         ` Michal Simek
2015-12-16  0:25           ` Thomas Chou
2015-12-11 11:54 ` [U-Boot] [PATCH 3/3] serial: uartlite: Add uartlite to Kconfig Michal Simek
2015-12-14 14:35   ` Thomas Chou
2015-12-14 15:42     ` Michal Simek [this message]
2015-12-15  4:02       ` Thomas Chou
2015-12-15 15:39         ` Michal Simek
2015-12-16  0:23           ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566EE351.8070808@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox