[U-Boot] [PATCH 3/3] serial: uartlite: Add uartlite to Kconfig

Thomas Chou
2015-12-15T04:02:11Z

Hi Michal,

On 2015?12?14? 23:42, Michal Simek wrote:
> On 14.12.2015 15:35, Thomas Chou wrote:
>> Hi Michal,
>>
>> On 2015?12?11? 19:54, Michal Simek wrote:
>>> - Move config option out of board file.
>>> - Remove uartlite address from config file
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>> ---
>>>
>>> board/xilinx/microblaze-generic/xparameters.h | 4 ----
>>> configs/microblaze-generic_defconfig | 1 +
>>> drivers/serial/Kconfig | 7 +++++++
>>> include/configs/microblaze-generic.h | 7 +------
>>> 4 files changed, 9 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/board/xilinx/microblaze-generic/xparameters.h
>>> b/board/xilinx/microblaze-generic/xparameters.h
>>> index 8ba146cb88db..11b3c9a4846e 100644
>>> --- a/board/xilinx/microblaze-generic/xparameters.h
>>> +++ b/board/xilinx/microblaze-generic/xparameters.h
>>> @@ -28,10 +28,6 @@
>>> #define XILINX_TIMER_BASEADDR 0x41c00000
>>> #define XILINX_TIMER_IRQ 0
>>>
>>> -/* Uart pheriphery is RS232_Uart */
>>> -#define XILINX_UARTLITE_BASEADDR 0x40600000
>>> -#define XILINX_UARTLITE_BAUDRATE 115200
>>> -
>>> /* IIC pheriphery is IIC_EEPROM */
>>> #define XILINX_IIC_0_BASEADDR 0x40800000
>>> #define XILINX_IIC_0_FREQ 100000
>>> diff --git a/configs/microblaze-generic_defconfig
>>> b/configs/microblaze-generic_defconfig
>>> index 5df080b6a87c..9a7bb915466f 100644
>>> --- a/configs/microblaze-generic_defconfig
>>> +++ b/configs/microblaze-generic_defconfig
>>> @@ -9,3 +9,4 @@ CONFIG_CMD_GPIO=y
>>> # CONFIG_CMD_SETEXPR is not set
>>> CONFIG_SPL_OF_CONTROL=y
>>> CONFIG_OF_EMBED=y
>>> +CONFIG_XILINX_UARTLITE=y
>>> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
>>> index f1e221799b81..ddf49ba9cef3 100644
>>> --- a/drivers/serial/Kconfig
>>> +++ b/drivers/serial/Kconfig
>>> @@ -230,4 +230,11 @@ config UNIPHIER_SERIAL
>>> If you have a UniPhier based board and want to use the on-chip
>>> serial ports, say Y to this option. If unsure, say N.
>>>
>>> +config XILINX_UARTLITE
>>> + bool "Xilinx Uarlite support"
>>> + depends on DM_SERIAL && (MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP)
>>> + help
>>> + If you have a Xilinx based board and want to use the uartlite
>>> + serial ports, say Y to this option. If unsure, say N.
>>> +
>>> endmenu
>>
>> Kconfig should be with the driver 1/3. Others are boards related.
>
> It can be. Adding Kconfig fragment can be separate patch out of move to
> DM. There is no connection too.
> My intention was to show all related changes which are done by this one
> step.

Please also make sure the patch series are bisectable.

Best regards,
Thomas