* [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()
@ 2015-12-14 15:53 Michal Simek
2015-12-14 22:14 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Michal Simek @ 2015-12-14 15:53 UTC (permalink / raw)
To: u-boot
Reported-by: Thomas Chou <thomas@wytron.com.tw>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/serial/serial_xuartlite.c | 2 +-
drivers/serial/serial_zynq.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
index fe87b515d902..0238a52380c7 100644
--- a/drivers/serial/serial_xuartlite.c
+++ b/drivers/serial/serial_xuartlite.c
@@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
};
#ifdef CONFIG_DEBUG_UART_UARTLITE
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
{
struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
index b2b98dea1561..3430482f8d8b 100644
--- a/drivers/serial/serial_zynq.c
+++ b/drivers/serial/serial_zynq.c
@@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
};
#ifdef CONFIG_DEBUG_UART_ZYNQ
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
{
struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()
2015-12-14 15:53 [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init() Michal Simek
@ 2015-12-14 22:14 ` Simon Glass
2015-12-15 4:20 ` Bin Meng
2015-12-15 8:40 ` Thomas Chou
2 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2015-12-14 22:14 UTC (permalink / raw)
To: u-boot
On 14 December 2015 at 08:53, Michal Simek <michal.simek@xilinx.com> wrote:
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/serial/serial_xuartlite.c | 2 +-
> drivers/serial/serial_zynq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()
2015-12-14 15:53 [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init() Michal Simek
2015-12-14 22:14 ` Simon Glass
@ 2015-12-15 4:20 ` Bin Meng
2015-12-15 15:29 ` Michal Simek
2015-12-15 8:40 ` Thomas Chou
2 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2015-12-15 4:20 UTC (permalink / raw)
To: u-boot
Hi Michal,
On Mon, Dec 14, 2015 at 11:53 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
Could you always include a simple sentence in the commit message?
>
> drivers/serial/serial_xuartlite.c | 2 +-
> drivers/serial/serial_zynq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index fe87b515d902..0238a52380c7 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
> };
>
> #ifdef CONFIG_DEBUG_UART_UARTLITE
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
> {
> struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
>
> diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
> index b2b98dea1561..3430482f8d8b 100644
> --- a/drivers/serial/serial_zynq.c
> +++ b/drivers/serial/serial_zynq.c
> @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
> };
>
> #ifdef CONFIG_DEBUG_UART_ZYNQ
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
> {
> struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
>
> --
Other than that,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()
2015-12-15 4:20 ` Bin Meng
@ 2015-12-15 15:29 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2015-12-15 15:29 UTC (permalink / raw)
To: u-boot
On 15.12.2015 05:20, Bin Meng wrote:
> Hi Michal,
>
> On Mon, Dec 14, 2015 at 11:53 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> Reported-by: Thomas Chou <thomas@wytron.com.tw>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>
> Could you always include a simple sentence in the commit message?
done in v2.
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()
2015-12-14 15:53 [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init() Michal Simek
2015-12-14 22:14 ` Simon Glass
2015-12-15 4:20 ` Bin Meng
@ 2015-12-15 8:40 ` Thomas Chou
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Chou @ 2015-12-15 8:40 UTC (permalink / raw)
To: u-boot
Hi Michal,
On 2015?12?14? 23:53, Michal Simek wrote:
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/serial/serial_xuartlite.c | 2 +-
> drivers/serial/serial_zynq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index fe87b515d902..0238a52380c7 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
> };
>
> #ifdef CONFIG_DEBUG_UART_UARTLITE
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
> {
> struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
>
> diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
> index b2b98dea1561..3430482f8d8b 100644
> --- a/drivers/serial/serial_zynq.c
> +++ b/drivers/serial/serial_zynq.c
> @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
> };
>
> #ifdef CONFIG_DEBUG_UART_ZYNQ
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
> {
> struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
>
>
Reviewed-by: Thomas Chou <thomas@wytron.com.tw>
Thanks,
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-15 15:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14 15:53 [U-Boot] [PATCH] serial: Use static inline for _debug_uart_init() Michal Simek
2015-12-14 22:14 ` Simon Glass
2015-12-15 4:20 ` Bin Meng
2015-12-15 15:29 ` Michal Simek
2015-12-15 8:40 ` Thomas Chou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox