From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Wed, 16 Dec 2015 08:23:08 +0800 Subject: [U-Boot] [PATCH 3/3] serial: uartlite: Add uartlite to Kconfig In-Reply-To: <5670344F.8040601@xilinx.com> References: <577e5f774bdaf68acfcaecd1052d7ebb6d64615a.1449834851.git.michal.simek@xilinx.com> <566ED3B2.5000202@wytron.com.tw> <566EE351.8070808@xilinx.com> <566F90C3.7050803@wytron.com.tw> <5670344F.8040601@xilinx.com> Message-ID: <5670AEEC.5080705@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michal, On 2015?12?15? 23:39, Michal Simek wrote: > On 15.12.2015 05:02, Thomas Chou wrote: >> Hi Michal, >> >> On 2015?12?14? 23:42, Michal Simek wrote: >>> On 14.12.2015 15:35, Thomas Chou wrote: >>>> Hi Michal, >>>> >>>> On 2015?12?11? 19:54, Michal Simek wrote: >>>>> - Move config option out of board file. >>>>> - Remove uartlite address from config file >>>>> >>>>> Signed-off-by: Michal Simek >>>>> --- >>>>> >>>>> board/xilinx/microblaze-generic/xparameters.h | 4 ---- >>>>> configs/microblaze-generic_defconfig | 1 + >>>>> drivers/serial/Kconfig | 7 +++++++ >>>>> include/configs/microblaze-generic.h | 7 +------ >>>>> 4 files changed, 9 insertions(+), 10 deletions(-) >>>>> >>>>> diff --git a/board/xilinx/microblaze-generic/xparameters.h >>>>> b/board/xilinx/microblaze-generic/xparameters.h >>>>> index 8ba146cb88db..11b3c9a4846e 100644 >>>>> --- a/board/xilinx/microblaze-generic/xparameters.h >>>>> +++ b/board/xilinx/microblaze-generic/xparameters.h >>>>> @@ -28,10 +28,6 @@ >>>>> #define XILINX_TIMER_BASEADDR 0x41c00000 >>>>> #define XILINX_TIMER_IRQ 0 >>>>> >>>>> -/* Uart pheriphery is RS232_Uart */ >>>>> -#define XILINX_UARTLITE_BASEADDR 0x40600000 >>>>> -#define XILINX_UARTLITE_BAUDRATE 115200 >>>>> - >>>>> /* IIC pheriphery is IIC_EEPROM */ >>>>> #define XILINX_IIC_0_BASEADDR 0x40800000 >>>>> #define XILINX_IIC_0_FREQ 100000 >>>>> diff --git a/configs/microblaze-generic_defconfig >>>>> b/configs/microblaze-generic_defconfig >>>>> index 5df080b6a87c..9a7bb915466f 100644 >>>>> --- a/configs/microblaze-generic_defconfig >>>>> +++ b/configs/microblaze-generic_defconfig >>>>> @@ -9,3 +9,4 @@ CONFIG_CMD_GPIO=y >>>>> # CONFIG_CMD_SETEXPR is not set >>>>> CONFIG_SPL_OF_CONTROL=y >>>>> CONFIG_OF_EMBED=y >>>>> +CONFIG_XILINX_UARTLITE=y >>>>> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig >>>>> index f1e221799b81..ddf49ba9cef3 100644 >>>>> --- a/drivers/serial/Kconfig >>>>> +++ b/drivers/serial/Kconfig >>>>> @@ -230,4 +230,11 @@ config UNIPHIER_SERIAL >>>>> If you have a UniPhier based board and want to use the on-chip >>>>> serial ports, say Y to this option. If unsure, say N. >>>>> >>>>> +config XILINX_UARTLITE >>>>> + bool "Xilinx Uarlite support" >>>>> + depends on DM_SERIAL && (MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP) >>>>> + help >>>>> + If you have a Xilinx based board and want to use the uartlite >>>>> + serial ports, say Y to this option. If unsure, say N. >>>>> + >>>>> endmenu >>>> >>>> Kconfig should be with the driver 1/3. Others are boards related. >>> >>> It can be. Adding Kconfig fragment can be separate patch out of move to >>> DM. There is no connection too. >>> My intention was to show all related changes which are done by this one >>> step. >> >> Please also make sure the patch series are bisectable. > > I am not aware about anything what would caused that this series is not > bisectable. Do you see something like that? No. Sorry. I didn't find DM and DM_serial in the microblaze repo at first. Then I found them in the patches earlier. Best regards, Thomas