From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Simek <michal.simek@xilinx.com>
Date: Wed, 16 Dec 2015 10:52:33 +0100
Subject: [U-Boot] [PATCH 11/12] net: emaclite: Move driver to DM
In-Reply-To: <CANr=Z=Zb66xUJSRcPLqXOkA9xnNR3Vot8T0ruo5t8Ph5s+PK_A@mail.gmail.com>
References: <cover.1449835419.git.michal.simek@xilinx.com>
 <7a4dd667dd86bcf18a68de1426f51cc0f3058244.1449835419.git.michal.simek@xilinx.com>
 <CANr=Z=Zb66xUJSRcPLqXOkA9xnNR3Vot8T0ruo5t8Ph5s+PK_A@mail.gmail.com>
Message-ID: <56713461.10306@xilinx.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 15.12.2015 23:34, Joe Hershberger wrote:
> On Fri, Dec 11, 2015 at 6:03 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> Move driver to DM.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> 
> A few nits below, but otherwise,
> 
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Thanks.

>> @@ -523,78 +520,105 @@ try_again:
>>
>>         debug("Packet receive from 0x%p, length %dB\n", addr, length);
>>         net_process_received_packet((uchar *)etherrxbuff, length);
>> -       return length;
>> +       return 0;
> 
> Since there is no clean-up here, it would be better to return the
> length and remove the net_process_received_packet() call above.

I will send it in separate patch. I wanted to do it in this way to be
smaller patch.

> 
>>
> 
> Remove this line.

done.

>> +
>> +static const struct eth_ops emaclite_ops = {
>> +       .start = emaclite_init,
> 
> Name this emaclite_start.
> 
>> +       .send = emaclite_send,
>> +       .recv = emaclite_recv,
>> +       .stop = emaclite_halt,
> 
> Name this emaclite_stop.

there will be separate patch for this.

Thanks,
Michal