From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Date: Thu, 17 Dec 2015 00:32:26 +0100
Subject: [U-Boot] [PATCH v2 1/5] lib: Add wait_for_bit
In-Reply-To: <201512162311.45697.marex@denx.de>
References: <1450303122-17884-1-git-send-email-mateusz.kulikowski@gmail.com>
 <1450303122-17884-2-git-send-email-mateusz.kulikowski@gmail.com>
 <201512162311.45697.marex@denx.de>
Message-ID: <5671F48A.90606@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Marek,

On 16.12.2015 23:11, Marek Vasut wrote:
> On Wednesday, December 16, 2015 at 10:58:38 PM, Mateusz Kulikowski wrote:
[...]
>> +#include <console.h>
>> +#include <asm/io.h>
>> +#include <asm/errno.h>
>> +
>> +int wait_for_bit(const char *prefix, const u32 *reg, const u32 mask,
>> +		 const bool set, const unsigned int timeout,
>> +		 const bool breakable)
>> +{
> 
> I wonder, what would happen if you stuffed this function into the header
> file altogether ? I think this would allow the compiler to do interprocedure
> optimalization on whichever file this would be included into. I wonder if
> that would have any impact on the resulting code size.
> 

Of course I can make it static inline.

I was suggested not to care about possible leftovers that are 
not garbage-collected by linker so didn't changed that on V2.

It's (max) few bytes that may be consumed by section alignment.


Regards,
Mateusz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWcfSBAAoJELvtohmVtQzB+BsIAJK6ZVnU80+rbjfzyBJCPUcJ
PtHLuz++kgkRZJevNr0RgUgiaWBs0eWfcN7FSpP3P1jUayGuE8MeYqJKbv7frlwO
lxxd+nvXJB5OiO0jZMShJjDDo/pzFeVz5iFGHi7e7Gglxbk5Q+WQ+Q2D2ZCra5SN
ktYReI4vViJWC2k+bGFYE4NL8p0OItdmT7gPpXPR8KOMg/Yq8MpQRZtCwCO3xNoU
Fj3kIwouCErF1AjHKQ1OXP7E/W6iw2jF/i1L28bnI4BX4ArACcf4QF6dNNrO63tX
jY322BHfyJG1sas2clMvq/QcA04jU2AQsx3poglJ6r9TTc72Kr3fxQl7IsNYS+s=
=LpYg
-----END PGP SIGNATURE-----