* [U-Boot] [PATCH] qemu-ppce500: pass 'range_id' around in pci_map_region
@ 2015-12-21 9:19 Miao Yan
2015-12-21 9:45 ` Bin Meng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Miao Yan @ 2015-12-21 9:19 UTC (permalink / raw)
To: u-boot
In pci_map_region(), pass 'range_id' to fdt_read_range(),
otherwise the same address will be mapped again in other
calls to pci_map_region()
Signed-off-by: Miao Yan <yammiaobest@gmail.com>
---
board/freescale/qemu-ppce500/qemu-ppce500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/qemu-ppce500/qemu-ppce500.c b/board/freescale/qemu-ppce500/qemu-ppce500.c
index a0fca0d..6cb5692 100644
--- a/board/freescale/qemu-ppce500/qemu-ppce500.c
+++ b/board/freescale/qemu-ppce500/qemu-ppce500.c
@@ -81,7 +81,7 @@ static int pci_map_region(void *fdt, int pci_node, int range_id,
ulong map_addr;
int r;
- r = fdt_read_range(fdt, pci_node, 0, NULL, &addr, &size);
+ r = fdt_read_range(fdt, pci_node, range_id, NULL, &addr, &size);
if (r)
return r;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] qemu-ppce500: pass 'range_id' around in pci_map_region
2015-12-21 9:19 [U-Boot] [PATCH] qemu-ppce500: pass 'range_id' around in pci_map_region Miao Yan
@ 2015-12-21 9:45 ` Bin Meng
2015-12-21 10:26 ` Alexander Graf
2016-01-04 22:23 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2015-12-21 9:45 UTC (permalink / raw)
To: u-boot
On Mon, Dec 21, 2015 at 5:19 PM, Miao Yan <yanmiaobest@gmail.com> wrote:
> In pci_map_region(), pass 'range_id' to fdt_read_range(),
> otherwise the same address will be mapped again in other
> calls to pci_map_region()
>
> Signed-off-by: Miao Yan <yammiaobest@gmail.com>
> ---
> board/freescale/qemu-ppce500/qemu-ppce500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] qemu-ppce500: pass 'range_id' around in pci_map_region
2015-12-21 9:19 [U-Boot] [PATCH] qemu-ppce500: pass 'range_id' around in pci_map_region Miao Yan
2015-12-21 9:45 ` Bin Meng
@ 2015-12-21 10:26 ` Alexander Graf
2016-01-04 22:23 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Graf @ 2015-12-21 10:26 UTC (permalink / raw)
To: u-boot
On 21.12.15 10:19, Miao Yan wrote:
> In pci_map_region(), pass 'range_id' to fdt_read_range(),
> otherwise the same address will be mapped again in other
> calls to pci_map_region()
>
> Signed-off-by: Miao Yan <yammiaobest@gmail.com>
Oops :).
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
> ---
> board/freescale/qemu-ppce500/qemu-ppce500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/qemu-ppce500/qemu-ppce500.c b/board/freescale/qemu-ppce500/qemu-ppce500.c
> index a0fca0d..6cb5692 100644
> --- a/board/freescale/qemu-ppce500/qemu-ppce500.c
> +++ b/board/freescale/qemu-ppce500/qemu-ppce500.c
> @@ -81,7 +81,7 @@ static int pci_map_region(void *fdt, int pci_node, int range_id,
> ulong map_addr;
> int r;
>
> - r = fdt_read_range(fdt, pci_node, 0, NULL, &addr, &size);
> + r = fdt_read_range(fdt, pci_node, range_id, NULL, &addr, &size);
> if (r)
> return r;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] qemu-ppce500: pass 'range_id' around in pci_map_region
2015-12-21 9:19 [U-Boot] [PATCH] qemu-ppce500: pass 'range_id' around in pci_map_region Miao Yan
2015-12-21 9:45 ` Bin Meng
2015-12-21 10:26 ` Alexander Graf
@ 2016-01-04 22:23 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2016-01-04 22:23 UTC (permalink / raw)
To: u-boot
On Mon, Dec 21, 2015 at 01:19:59AM -0800, Miao Yan wrote:
> In pci_map_region(), pass 'range_id' to fdt_read_range(),
> otherwise the same address will be mapped again in other
> calls to pci_map_region()
>
> Signed-off-by: Miao Yan <yammiaobest@gmail.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Alexander Graf <agraf@suse.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160104/c8ffe5ca/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-04 22:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-21 9:19 [U-Boot] [PATCH] qemu-ppce500: pass 'range_id' around in pci_map_region Miao Yan
2015-12-21 9:45 ` Bin Meng
2015-12-21 10:26 ` Alexander Graf
2016-01-04 22:23 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox