public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/8] drivers/pci: Fix for debug builds without CONFIG_PCI_ENUM_ONLY
Date: Tue, 22 Dec 2015 09:06:15 +0100	[thread overview]
Message-ID: <56790477.6040507@denx.de> (raw)
In-Reply-To: <20151221232449.653FC61223@mail.nwl.cc>

(adding Simon and Bin to Cc)

On 22.12.2015 00:25, Phil Sutter wrote:
> The debug printing references bar_res, which exists only if
> CONFIG_PCI_ENUM_ONLY is not defined. Therefore move it into the ifdef'd
> area.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
>   drivers/pci/pci_auto_old.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci_auto_old.c b/drivers/pci/pci_auto_old.c
> index 932eab8..8f17779 100644
> --- a/drivers/pci/pci_auto_old.c
> +++ b/drivers/pci/pci_auto_old.c
> @@ -98,11 +98,11 @@ void pciauto_setup_device(struct pci_controller *hose,
>   				bar_res = prefetch;
>   			else
>   				bar_res = mem;
> -#endif
>
>   			debug("PCI Autoconfig: BAR %d, %s, size=0x%llx, ",
>   			      bar_nr, bar_res == prefetch ? "Prf" : "Mem",
>   			      (unsigned long long)bar_size);
> +#endif
>   		}
>
>   #ifndef CONFIG_PCI_ENUM_ONLY
>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2015-12-22  8:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1450740358-5014-1-git-send-email-phil@nwl.cc>
2015-12-21 23:25 ` [U-Boot] [PATCH v2 1/8] drivers/pci: Fix for debug builds without CONFIG_PCI_ENUM_ONLY Phil Sutter
2015-12-22  8:06   ` Stefan Roese [this message]
2015-12-21 23:25 ` [U-Boot] [PATCH v2 2/8] mvebu: Fix for non-DM ehci-marvell support Phil Sutter
2015-12-22  8:02   ` Stefan Roese
2015-12-22 14:24     ` Phil Sutter
2015-12-22 14:27       ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 3/8] README: Review the u-boot porting guide list Phil Sutter
2015-12-22  8:08   ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 4/8] axp: Fix debugging support in DDR3 write leveling Phil Sutter
2015-12-22  8:08   ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 5/8] drivers/pci/pci_mvebu: Fix for boards with X4 lanes Phil Sutter
2015-12-22  8:24   ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 6/8] mvebu: Add rudimental MV78320 support Phil Sutter
2015-12-22  8:32   ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 7/8] mvebu: Support Synology DS414 Phil Sutter
2015-12-22  9:05   ` Stefan Roese
2015-12-23  0:31     ` Phil Sutter
2015-12-23  7:56       ` Stefan Roese
2015-12-23 11:30         ` Phil Sutter
2015-12-23 11:43           ` Stefan Roese
2017-06-16 14:04   ` Bin Meng
2015-12-21 23:25 ` [U-Boot] [PATCH v2 8/8] common: Implement Synology specific command set Phil Sutter
2015-12-22  9:06   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56790477.6040507@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox