[U-Boot] [PATCH v2 2/8] mvebu: Fix for non-DM ehci-marvell support

Stefan Roese
2015-12-22T14:27:02Z

Hi Phil,

On 22.12.2015 15:24, Phil Sutter wrote:
> On Tue, Dec 22, 2015 at 09:02:44AM +0100, Stefan Roese wrote:
>> On 22.12.2015 00:25, Phil Sutter wrote:
>>> This mimics the relevant code in mach-kirkwood headers. The
>>> *_winctrl_calcsize functions are identical, as well as the MVCPU_WIN_*
>>> macros. Implementing shared headers/code between mvebu and kirkwood is
>>> left for someone with a better knowledge of how u-boot is organized
>>> internally.
>>
>> Why do you need this functionality on your Armada XP board? It
>> should be able to use the DM enabled ehci-marvell driver.
>
> Yes, it works without as long as CONFIG_DM_USB is enabled. Yet I thought
> fixing it nevertheless was desirable to allow for testing or whatever
> without.

Using a driver that supports DM on a platform that supports DM is
the way to go. On the long run, all driver and platforms will
get converted to DM.

> If you don't see any use in it, I can drop this from the upcoming V3 of
> course.

Yes, please drop it.

> OTOH maybe we should enforce DM_USB for Armada XP boards with
> ehci-marvell enabled?

Yes. I think once all the patches have reached mainline (after the
next release), such an automatic selection of the DM_xxx stuff should
be done.

Thanks,
Stefan