From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 10/16] drivers: mtd: spi: sf_probe: add compatible for spansion spi flash
Date: Wed, 23 Dec 2015 17:31:00 +0530 [thread overview]
Message-ID: <567A8CFC.1010201@ti.com> (raw)
In-Reply-To: <CAD6G_RTPk9jwjUL-Buzrzxy_o8BivmD+Ed5m4i0+qtnjvMBi8g@mail.gmail.com>
On Wednesday 23 December 2015 05:02 PM, Jagan Teki wrote:
> On 23 December 2015 at 16:29, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> On Wednesday 23 December 2015 04:21 PM, Jagan Teki wrote:
>>> On 23 December 2015 at 15:29, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>>>> Add compatible for spansion 32MiB spi flash s25fl256s1.
>>>>
>>>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>>>> ---
>>>> drivers/mtd/spi/sf_probe.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
>>>> index daa1d5b..c691b6c 100644
>>>> --- a/drivers/mtd/spi/sf_probe.c
>>>> +++ b/drivers/mtd/spi/sf_probe.c
>>>> @@ -166,6 +166,7 @@ static const struct dm_spi_flash_ops spi_flash_std_ops = {
>>>>
>>>> static const struct udevice_id spi_flash_std_ids[] = {
>>>> { .compatible = "spi-flash" },
>>>> + { .compatible = "s25fl256s1" },
>>>> { }
>>>
>>> I think we had discussion [1] to use spi-flash now and re-spin the
>>> things later - am I missing anything here?
>>>
>>> [1] https://patchwork.ozlabs.org/patch/546345/
>>>
>>
>> My assumption from the discussion is to add these compatibles for now
>> and when dts files are added with spi-flash compatible we can trim out
>> these compatibles.
>
> I thought you understand it quite different, Please do what others do
> as of now means use spi-flash. and coming version will trim as
> compatible with Linux.
>
you mean adding spi-flash compatible to dts file?
Regards
Mugunthan V N
next prev parent reply other threads:[~2015-12-23 12:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 9:59 [U-Boot] [PATCH v5 00/16] device model bring-up of ti-qspi on dra72, dra74 and am437x-sk evm Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 01/16] drivers: spi: ti_qspi: do not hard code chip select for memory map configuration Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 02/16] drivers: spi:ti_qspi: change ti_qspi_slave to ti_qspi_priv for driver model conversion Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 03/16] drivers: spi: ti_qspi: prepare driver for DM conversion Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 04/16] dm: core: Add a new api to get indexed device address Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 05/16] spi: Add support for dual and quad mode Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 06/16] dra7xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 07/16] dts: dra7: add spi alias for qspi Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 08/16] drivers: spi: ti_qspi: convert driver to adopt device driver model Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 09/16] arm: dts: dra7: add qspi register maps for memory map and control module Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 10/16] drivers: mtd: spi: sf_probe: add compatible for spansion spi flash Mugunthan V N
2015-12-23 10:51 ` Jagan Teki
2015-12-23 10:59 ` Mugunthan V N
2015-12-23 11:32 ` Jagan Teki
2015-12-23 12:01 ` Mugunthan V N [this message]
2015-12-23 9:59 ` [U-Boot] [PATCH v5 11/16] drivers: mtd: spi: sf_probe: add compatible for Macronix " Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 12/16] defconfig: dra72_evm: enable spi driver model Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 13/16] defconfig: dra74_evm: " Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 14/16] am43xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 15/16] arm: dts: am4372: add qspi register maps for memory map Mugunthan V N
2015-12-23 9:59 ` [U-Boot] [PATCH v5 16/16] defconfig: am437x_sk_evm: enable spi driver model Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567A8CFC.1010201@ti.com \
--to=mugunthanvnm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox