From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Date: Wed, 23 Dec 2015 17:31:00 +0530 Subject: [U-Boot] [PATCH v5 10/16] drivers: mtd: spi: sf_probe: add compatible for spansion spi flash In-Reply-To: References: <1450864762-24219-1-git-send-email-mugunthanvnm@ti.com> <1450864762-24219-11-git-send-email-mugunthanvnm@ti.com> <567A7EA7.1060306@ti.com> Message-ID: <567A8CFC.1010201@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 23 December 2015 05:02 PM, Jagan Teki wrote: > On 23 December 2015 at 16:29, Mugunthan V N wrote: >> On Wednesday 23 December 2015 04:21 PM, Jagan Teki wrote: >>> On 23 December 2015 at 15:29, Mugunthan V N wrote: >>>> Add compatible for spansion 32MiB spi flash s25fl256s1. >>>> >>>> Signed-off-by: Mugunthan V N >>>> --- >>>> drivers/mtd/spi/sf_probe.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c >>>> index daa1d5b..c691b6c 100644 >>>> --- a/drivers/mtd/spi/sf_probe.c >>>> +++ b/drivers/mtd/spi/sf_probe.c >>>> @@ -166,6 +166,7 @@ static const struct dm_spi_flash_ops spi_flash_std_ops = { >>>> >>>> static const struct udevice_id spi_flash_std_ids[] = { >>>> { .compatible = "spi-flash" }, >>>> + { .compatible = "s25fl256s1" }, >>>> { } >>> >>> I think we had discussion [1] to use spi-flash now and re-spin the >>> things later - am I missing anything here? >>> >>> [1] https://patchwork.ozlabs.org/patch/546345/ >>> >> >> My assumption from the discussion is to add these compatibles for now >> and when dts files are added with spi-flash compatible we can trim out >> these compatibles. > > I thought you understand it quite different, Please do what others do > as of now means use spi-flash. and coming version will trim as > compatible with Linux. > you mean adding spi-flash compatible to dts file? Regards Mugunthan V N