From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Thu, 24 Dec 2015 13:24:45 +0800 Subject: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress In-Reply-To: <201512240442.38958.marex@denx.de> References: <1450918284-16174-1-git-send-email-thomas@wytron.com.tw> <201512240402.24738.marex@denx.de> <567B6601.7060409@wytron.com.tw> <201512240442.38958.marex@denx.de> Message-ID: <567B819D.4060805@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On 2015?12?24? 11:42, Marek Vasut wrote: > On Thursday, December 24, 2015 at 04:26:57 AM, Thomas Chou wrote: >> Hi Marek, > > Hi Thomas, > >> On 2015?12?24? 11:02, Marek Vasut wrote: >>> On Thursday, December 24, 2015 at 03:50:57 AM, Thomas Chou wrote: >>>> Hi Marek, >>>> >>>> On 2015?12?24? 09:29, Marek Vasut wrote: >>>>> On Thursday, December 24, 2015 at 01:51:23 AM, Thomas Chou wrote: >>>>>> Show sector erase progress with dot and comma. >>>>>> >>>>>> Signed-off-by: Thomas Chou >>>>>> --- >>>>> >>>>> Shouldn't this go into common code ? >>>> >>>> The code to print a dot is minimal. It will cost more if this go into >>>> common code. >>> >>> But then this driver behaves in a non-standard manner AND noone benefits >>> from this functionality but this driver. >> >> The sector erase might take very long when there are a lot of sectors to >> erase, say 12 min to 50 min for 1024 sectors on the 10m50 board. Without >> the display of progress, it will look like the board hangs. > > Yeah, that I do understand and I agree this is a good idea :) > >> The dotting code comes from the old cfi_flash.c. Some other parallel >> flash have this, but not spi-flash. It is trivial to add though. > > Urm, altera_qspi is CFI, right ? So can we stuff this into common code or not? > Sorry if I am confused and off the mark. No worries. I think the dotting is best done per driver. We can have common behavior. But there is little advantage to make it common code. Merry Xmas. Thomas Chou