From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 02/19] dm: timer: uclass: add timer init to add timer device
Date: Fri, 25 Dec 2015 12:38:42 +0530 [thread overview]
Message-ID: <567CEB7A.8030202@ti.com> (raw)
In-Reply-To: <CAEUhbmVm_fPUe6QJDHP2WGiJKG7piY4i42oj8n1KDoxbjgSi1Q@mail.gmail.com>
On Friday 25 December 2015 07:40 AM, Bin Meng wrote:
>> + /* Check for a chosen timer to be used for tick */
>> > + node = fdtdec_get_chosen_node(blob, "tick-timer");
>> > + if (node < 0)
>> > + return -ENODEV;
> This changes now require every device tree provide a "tick-timer"
> under /chosen, which break all the existing dm timer enabled boards,
> and is not necessary.
>
> We should do:
>
> if (node < 0) {
> ret = uclass_first_device(UCLASS_TIMER, &dev);
> if (ret)
> return ret;
> if (!dev)
> return -ENODEV;
> gd->timer = dev;
> } else {
> ....
> }
>
Oops!, will fix it in next version.
Regards
Mugunthan V N
next prev parent reply other threads:[~2015-12-25 7:08 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 10:38 [U-Boot] [PATCH v2 00/19] driver model bring-up of omap timer on dra72, dra74, am335x and am437x-sk evm Mugunthan V N
2015-12-24 10:38 ` [U-Boot] [PATCH v2 01/19] arm: omap-common: do not build timer when CONFIG_TIMER defined Mugunthan V N
2016-01-04 19:57 ` Tom Rini
2016-01-16 1:20 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 02/19] dm: timer: uclass: add timer init to add timer device Mugunthan V N
2015-12-25 2:10 ` Bin Meng
2015-12-25 7:08 ` Mugunthan V N [this message]
2015-12-25 10:41 ` [U-Boot] [PATCH v3 " Mugunthan V N
2015-12-25 12:13 ` Bin Meng
2015-12-25 13:08 ` Mugunthan V N
2016-01-16 1:20 ` Simon Glass
2016-01-16 16:03 ` [U-Boot] [PATCH v4 02/19] dm: timer: uclass: add timer init in uclass driver " Mugunthan V N
2016-01-16 16:08 ` Mugunthan V N
2016-01-16 16:41 ` Simon Glass
2016-01-16 16:51 ` Mugunthan V N
2016-01-18 3:58 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 03/19] dm: timer: uclass: Add flag to control sequence numbering Mugunthan V N
2016-01-04 19:57 ` Tom Rini
2016-01-06 0:25 ` Simon Glass
2016-01-16 1:21 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 04/19] drivers: timer: omap_timer: add timer driver for omap devices based on dm Mugunthan V N
2016-01-04 19:57 ` Tom Rini
2016-01-16 1:21 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 05/19] am43xx_evm: timer: do not define CONFIG_TIMER for spl Mugunthan V N
2016-01-04 19:57 ` Tom Rini
2016-01-16 1:21 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 06/19] arm: dts: am437x-sk-evm: add tick-timer to chosen node Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 07/19] defconfig: am437x_sk_evm: enable timer driver model Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 08/19] arm: dts: am437x-gp-evm: add tick-timer to chosen node Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 09/19] defconfig: am437x_gp_evm: enable timer driver model Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 10/19] am335x_evm: timer: do not define CONFIG_TIMER for spl Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 11/19] arm: dts: am335x-boneblack: add tick-timer to chosen node Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 12/19] defconfig: am335x_boneblack_vboot: enable timer driver model Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 13/19] arm: dts: am335x-evm: add tick-timer to chosen node Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 14/19] defconfig: am335x_gp_evm: enable timer driver model Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 15/19] ti_omap5_common: timer: do not define CONFIG_TIMER for spl Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 16/19] arm: dts: dra72-evm: add tick-timer to chosen node Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 17/19] defconfig: dra72_evm: enable timer driver model Mugunthan V N
2016-01-04 19:58 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 18/19] arm: dts: dra7-evm: add tick-timer to chosen node Mugunthan V N
2016-01-04 19:59 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
2015-12-24 10:38 ` [U-Boot] [PATCH v2 19/19] defconfig: dra74_evm: enable timer driver model Mugunthan V N
2016-01-04 19:59 ` Tom Rini
2016-01-16 1:22 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567CEB7A.8030202@ti.com \
--to=mugunthanvnm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox