From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Date: Fri, 25 Dec 2015 12:38:42 +0530 Subject: [U-Boot] [PATCH v2 02/19] dm: timer: uclass: add timer init to add timer device In-Reply-To: References: <1450953502-6181-1-git-send-email-mugunthanvnm@ti.com> <1450953502-6181-3-git-send-email-mugunthanvnm@ti.com> Message-ID: <567CEB7A.8030202@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 25 December 2015 07:40 AM, Bin Meng wrote: >> + /* Check for a chosen timer to be used for tick */ >> > + node = fdtdec_get_chosen_node(blob, "tick-timer"); >> > + if (node < 0) >> > + return -ENODEV; > This changes now require every device tree provide a "tick-timer" > under /chosen, which break all the existing dm timer enabled boards, > and is not necessary. > > We should do: > > if (node < 0) { > ret = uclass_first_device(UCLASS_TIMER, &dev); > if (ret) > return ret; > if (!dev) > return -ENODEV; > gd->timer = dev; > } else { > .... > } > Oops!, will fix it in next version. Regards Mugunthan V N