From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F1F3C7EE2F for ; Mon, 12 Jun 2023 18:14:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E93A8601B; Mon, 12 Jun 2023 20:14:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZowmWJfm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EA8C4860BB; Mon, 12 Jun 2023 20:14:28 +0200 (CEST) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5BA0B85FF0 for ; Mon, 12 Jun 2023 20:14:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jernej.skrabec@gmail.com Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9786fc23505so682528066b.2 for ; Mon, 12 Jun 2023 11:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686593666; x=1689185666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E6JHdZn+O4dMKv8LF9TvlJrz0eZhBcVwfrfrw9rJjm4=; b=ZowmWJfmPaoTmsciYYI+YJhKb4zXkNBQFsSBWH9DvLLji5pT1UWVy83UcP9vlAk+k3 VIrPZORPVS0ofoNMxrDxAtAJT0R9pLxrSaXLax7VcCx+CcBJVwXUF+qLpFLXAhPhyteo tTUnJIxt5sWFNctZCEqUrlMNK7O45ImvGn8mGMXDQt/gyWWuN/xex7TbfQNO+deR+Uq3 b48vNg5wIfehjklwERIcgggQ3ycwBcdLsElZxU7qQqjRgMe+Na3rMlMrrdCLYkFz5NoO OoCg4/Ky1Zh3xZcrhv04qEk8/6h/hRO1X9dw7EOvs7fZDEzzNNkNgfFR1JeBVUyLejnV 7AbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686593666; x=1689185666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E6JHdZn+O4dMKv8LF9TvlJrz0eZhBcVwfrfrw9rJjm4=; b=LhUTkedRk+Lo9z/shVqmeQXTJy5ZnjASm1cCaB2TVjpZB7MG+Wx2zEE2rwHmrnem13 w+atkAWXcZIc4eVekCgKxVMyOg3TDEWOXe6G9++myEzuEb2Vlirbvel3R1/GRqsoJxfm 4XMvhFt34K/HJtcFzPCO4DuHo4jWbi0+9ZRdkuTa2wndBOXoOREhM+v1V8fGqasTV2e4 b6hyM/1ESOEPvO0vkbBhqUlDhnhMGAR96Crtc60i4p4ZYf23N36ovUvIq7crFvgBsRBO 3YNHUb8JKzNweyBIENkWCYFsTjbgm+hyVPrQTzh8rdRvHLkSw7SXVWKRZqZbHUHapkRp ar4w== X-Gm-Message-State: AC+VfDyTjqmW/alv6ZQDJx1jzez1QrVQyYx6fEsnjIs9Dm+YbuGLAzQf h3pKhfhWq+m/shOFtUmgtik= X-Google-Smtp-Source: ACHHUZ6ODS8vmXcPpLoZXv/He+xNMacvJwlvriNHgycSFTDZfvImooRxhA0tl4yo+LN+k3NJJRq2AQ== X-Received: by 2002:a17:907:ea1:b0:973:d85b:9ed9 with SMTP id ho33-20020a1709070ea100b00973d85b9ed9mr11925772ejc.72.1686593665626; Mon, 12 Jun 2023 11:14:25 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id ce14-20020a170906b24e00b00977cc3d37a2sm5480550ejb.133.2023.06.12.11.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:14:25 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Jagan Teki , Andre Przywara Cc: Marek Vasut , Samuel Holland , Icenowy Zheng , Sam Edwards , =?utf-8?B?6Lev6L6J?= , u-boot@lists.denx.de, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 5/7] phy: sun4i-usb: Add H616 USB PHY quirk support Date: Mon, 12 Jun 2023 20:14:20 +0200 Message-ID: <5680571.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20230611233241.14235-6-andre.przywara@arm.com> References: <20230611233241.14235-1-andre.przywara@arm.com> <20230611233241.14235-6-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Dne ponedeljek, 12. junij 2023 ob 01:32:39 CEST je Andre Przywara napisal(a): > The H616 USB PHY is some kind of special snowflake: Only port2 works out > of the box, but all other ports need some help from this port2 to work > correctly: The CLK_BUS_PHY2 and RST_USB_PHY2 clock and reset need to be > enabled, and the SIDDQ bit in the PMU PHY control register needs to be > cleared. For this register to be accessible, CLK_BUS_ECHI2 needs to be > ungated. Don't ask .... > > Follow the respective Linux patch (b45c6d80325b) and add a quirk bit, > triggering the special sequence as outlined above, for PHYs other than > PHY2: ungate this one special clock, and clear the SIDDQ bit. We also > pick the clock and reset from PHY2 and enable them as well. > > Signed-off-by: Andre Przywara Reviewed-by: Jernej Skrabec Best regards, Jernej