public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 4/5] mips: ath79: add spi driver
Date: Tue, 29 Dec 2015 21:00:27 +0800	[thread overview]
Message-ID: <568283EB.7000003@wytron.com.tw> (raw)
In-Reply-To: <BLU436-SMTP175B0C852CA31B66DC45984FFFC0@phx.gbl>

Hi Wills,

On 2015?12?29? 19:17, Wills Wang wrote:
> diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig
> index 1d92a5b..b5668e9 100644
> --- a/arch/mips/mach-ath79/Kconfig
> +++ b/arch/mips/mach-ath79/Kconfig
> @@ -15,6 +15,7 @@ config SOC_AR933X
>   	select SYS_MIPS_CACHE_INIT_RAM_LOAD
>   	select MIPS_TUNE_24KC
>   	select AR933X_UART
> +	select ATH79_SPI

Both AR933X_UART and ATH79_SPI should not be selected with mach Kconfig. 
They should go with board defconfig.

> diff --git a/drivers/spi/ath79_spi.c b/drivers/spi/ath79_spi.c

> +static inline void ath79_spi_delay(int max_hz)
> +{
> +	uint64_t tick = get_tbclk();
> +
> +	do_div(tick, max_hz);
> +	tick = get_ticks() + tick + 1;	/* get current timestamp */
> +	while (get_ticks() < tick)	/* loop till event */
> +		 /*NOP*/;
> +}

Use udelay() instead.

Best regards,
Thomas

  reply	other threads:[~2015-12-29 13:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1451387833-932-1-git-send-email-wills.wang@live.com>
2015-12-29 11:17 ` [U-Boot] [PATCH v5 1/5] mips: implement to access the KSEG0/1 memory range in map_physmem Wills Wang
2015-12-29 12:49   ` Antony Pavlov
2015-12-30  1:08     ` Wills Wang
2015-12-29 18:08   ` Daniel Schwierzeck
2015-12-29 11:17 ` [U-Boot] [PATCH v5 2/5] mips: add support for QCA/Atheros ath79 SOCs Wills Wang
2015-12-29 19:09   ` Daniel Schwierzeck
2015-12-30  6:27     ` Wills Wang
2015-12-29 11:17 ` [U-Boot] [PATCH v5 3/5] mips: ath79: add serial driver for ar933x SOC Wills Wang
2015-12-29 12:26   ` Thomas Chou
2015-12-30  1:06     ` Wills Wang
2015-12-29 11:17 ` [U-Boot] [PATCH v5 4/5] mips: ath79: add spi driver Wills Wang
2015-12-29 13:00   ` Thomas Chou [this message]
2015-12-29 13:25     ` Marek Vasut
2015-12-29 23:46       ` Thomas Chou
2015-12-30  0:51         ` Marek Vasut
2015-12-30  4:02           ` Thomas Chou
2015-12-30  8:32           ` Antony Pavlov
2015-12-30  8:55             ` Marek Vasut
2015-12-30  1:35       ` Wills Wang
2015-12-30  1:46         ` Marek Vasut
2015-12-30  1:12     ` Wills Wang
2015-12-29 11:17 ` [U-Boot] [PATCH v5 5/5] mips: ath79: add AP121 reference board Wills Wang
2015-12-29 19:27   ` Daniel Schwierzeck
2015-12-30  6:31     ` Wills Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568283EB.7000003@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox