public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 2/2] arm: mx5: Add support for DENX M53EVK
Date: Fri, 3 May 2013 16:59:13 +0200 (CEST)	[thread overview]
Message-ID: <568408995.526788.1367593153328.JavaMail.root@advansee.com> (raw)
In-Reply-To: <1366920963-8646-2-git-send-email-marex@denx.de>

Dear Marek Vasut,

On Thursday, April 25, 2013 10:16:03 PM, Marek Vasut wrote:
> Add basic support for the DENX M53EVK board. Currently supported is:
> MMC (incl. booting)
> NAND (incl. booting)
> Ethernet, I2C, USB, SATA, RTC.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
[...]
> diff --git a/board/denx/m53evk/m53evk.c b/board/denx/m53evk/m53evk.c
> new file mode 100644
> index 0000000..3289f28
> --- /dev/null
> +++ b/board/denx/m53evk/m53evk.c
> @@ -0,0 +1,408 @@
[...]
> +#ifdef CONFIG_USB_EHCI_MX5
> +int board_ehci_hcd_init(int port)
> +{
> +	if (port == 0) {
> +		/* USB OTG PWRON */
> +		mxc_request_iomux(MX53_PIN_GPIO_4, IOMUX_CONFIG_ALT1);
> +		mxc_iomux_set_pad(MX53_PIN_GPIO_4,
> +				PAD_CTL_PKE_ENABLE |
> +				PAD_CTL_100K_PD |
> +				PAD_CTL_DRV_HIGH
> +				);
> +		gpio_direction_output(IOMUX_TO_GPIO(MX53_PIN_GPIO_4), 0);
> +
> +		/* USB OTG Over Current */
> +		mxc_request_iomux(MX53_PIN_GPIO_18, IOMUX_CONFIG_ALT1);
> +		mxc_iomux_set_input(MX53_USBOH3_IPP_IND_OTG_OC_SELECT_INPUT, 1);

It looks like there is something wrong here: The last line connects OTG.OC to
EIM_D21.ALT6, but the line before sets GPIO_18 as GPIO7[13] instead of setting
EIM_D21 as OTG.OC.

Best regards,
Beno?t

  parent reply	other threads:[~2013-05-03 14:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 20:16 [U-Boot] [PATCH 1/2] tools: arm: imx: Implement BOOT_OFFSET command for imximage Marek Vasut
2013-04-25 20:16 ` [U-Boot] [PATCH V3 2/2] arm: mx5: Add support for DENX M53EVK Marek Vasut
2013-04-25 21:42   ` Wolfgang Denk
2013-04-26  1:07     ` Marek Vasut
2013-05-03 14:59   ` Benoît Thébaudeau [this message]
2013-05-03 15:09     ` Benoît Thébaudeau
2013-05-03 17:31     ` Benoît Thébaudeau
2013-05-03 19:56       ` Marek Vasut
2013-05-03 20:06         ` Benoît Thébaudeau
2013-05-03 20:17           ` Marek Vasut
2013-05-05 15:57   ` Stefano Babic
2013-04-25 21:29 ` [U-Boot] [PATCH 1/2] tools: arm: imx: Implement BOOT_OFFSET command for imximage Benoît Thébaudeau
2013-04-26  0:57   ` Marek Vasut
2013-04-26  7:11     ` Benoît Thébaudeau
2013-04-26  8:19 ` Stefano Babic
2013-04-26  8:49 ` Stefan Roese
2013-04-28  9:19 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568408995.526788.1367593153328.JavaMail.root@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox