* [U-Boot] [PATCH v2 2/3] mx6sabresd: Simplify the Ethernet PHY configuration
2016-01-05 19:02 [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Fabio Estevam
@ 2016-01-05 19:02 ` Fabio Estevam
2016-01-05 21:07 ` Joe Hershberger
2016-01-05 19:02 ` [U-Boot] [PATCH v2 3/3] wandboard: " Fabio Estevam
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Fabio Estevam @ 2016-01-05 19:02 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@nxp.com>
As per the AR8031 datasheet:
"For a reliable power on reset, suggest to keep asserting the reset
low long enough (10ms) to ensure the clock is stable and clock-to-reset
1ms requirement is satisfied."
So do as suggested and also add a 100us delay after deasserting the
reset line to guarantee that the PHY ID can be read correctly and the
Atheros 8031 PHY driver can be loaded automatically.
This results in a simpler code.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
This is 2016.04 material.
Changes since v1:
- None
board/freescale/mx6sabresd/mx6sabresd.c | 36 ++-------------------------------
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index 581c9d5..d20953d 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -94,8 +94,9 @@ static void setup_iomux_enet(void)
/* Reset AR8031 PHY */
gpio_direction_output(IMX_GPIO_NR(1, 25) , 0);
- udelay(500);
+ mdelay(10);
gpio_set_value(IMX_GPIO_NR(1, 25), 1);
+ udelay(100);
}
static iomux_v3_cfg_t const usdhc2_pads[] = {
@@ -340,39 +341,6 @@ int board_mmc_init(bd_t *bis)
}
#endif
-int mx6_rgmii_rework(struct phy_device *phydev)
-{
- unsigned short val;
-
- /* To enable AR8031 ouput a 125MHz clk from CLK_25M */
- phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7);
- phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016);
- phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
-
- val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
- val &= 0xffe3;
- val |= 0x18;
- phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val);
-
- /* introduce tx clock delay */
- phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5);
- val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
- val |= 0x0100;
- phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val);
-
- return 0;
-}
-
-int board_phy_config(struct phy_device *phydev)
-{
- mx6_rgmii_rework(phydev);
-
- if (phydev->drv->config)
- phydev->drv->config(phydev);
-
- return 0;
-}
-
#if defined(CONFIG_VIDEO_IPUV3)
static void disable_lvds(struct display_info_t const *dev)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v2 2/3] mx6sabresd: Simplify the Ethernet PHY configuration
2016-01-05 19:02 ` [U-Boot] [PATCH v2 2/3] mx6sabresd: Simplify the Ethernet PHY configuration Fabio Estevam
@ 2016-01-05 21:07 ` Joe Hershberger
0 siblings, 0 replies; 13+ messages in thread
From: Joe Hershberger @ 2016-01-05 21:07 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> As per the AR8031 datasheet:
>
> "For a reliable power on reset, suggest to keep asserting the reset
> low long enough (10ms) to ensure the clock is stable and clock-to-reset
> 1ms requirement is satisfied."
>
> So do as suggested and also add a 100us delay after deasserting the
> reset line to guarantee that the PHY ID can be read correctly and the
> Atheros 8031 PHY driver can be loaded automatically.
>
> This results in a simpler code.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 3/3] wandboard: Simplify the Ethernet PHY configuration
2016-01-05 19:02 [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Fabio Estevam
2016-01-05 19:02 ` [U-Boot] [PATCH v2 2/3] mx6sabresd: Simplify the Ethernet PHY configuration Fabio Estevam
@ 2016-01-05 19:02 ` Fabio Estevam
2016-01-05 21:06 ` Joe Hershberger
2016-01-07 16:50 ` Stefano Babic
2016-01-05 19:06 ` [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Joe Hershberger
` (4 subsequent siblings)
6 siblings, 2 replies; 13+ messages in thread
From: Fabio Estevam @ 2016-01-05 19:02 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@nxp.com>
As per the AR8031 datasheet:
"For a reliable power on reset, suggest to keep asserting the reset
low long enough (10ms) to ensure the clock is stable and clock-to-reset
1ms requirement is satisfied."
So do as suggested and also add a 100us delay after deasserting the
reset line to guarantee that the PHY ID can be read correctly and the
Atheros 8031 PHY driver can be loaded automatically.
This results in a simpler code.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
This is 2016.04 material.
Changes since v1:
- Use mdelay instead of udelay
board/wandboard/wandboard.c | 36 ++----------------------------------
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 0af63d2..5fb7117 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -121,8 +121,9 @@ static void setup_iomux_enet(void)
/* Reset AR8031 PHY */
gpio_direction_output(ETH_PHY_RESET, 0);
- udelay(500);
+ mdelay(10);
gpio_set_value(ETH_PHY_RESET, 1);
+ udelay(100);
}
static struct fsl_esdhc_cfg usdhc_cfg[2] = {
@@ -187,39 +188,6 @@ int board_mmc_init(bd_t *bis)
return 0;
}
-static int mx6_rgmii_rework(struct phy_device *phydev)
-{
- unsigned short val;
-
- /* To enable AR8031 ouput a 125MHz clk from CLK_25M */
- phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7);
- phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016);
- phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
-
- val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
- val &= 0xffe3;
- val |= 0x18;
- phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val);
-
- /* introduce tx clock delay */
- phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5);
- val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
- val |= 0x0100;
- phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val);
-
- return 0;
-}
-
-int board_phy_config(struct phy_device *phydev)
-{
- mx6_rgmii_rework(phydev);
-
- if (phydev->drv->config)
- phydev->drv->config(phydev);
-
- return 0;
-}
-
#if defined(CONFIG_VIDEO_IPUV3)
struct i2c_pads_info mx6q_i2c2_pad_info = {
.scl = {
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v2 3/3] wandboard: Simplify the Ethernet PHY configuration
2016-01-05 19:02 ` [U-Boot] [PATCH v2 3/3] wandboard: " Fabio Estevam
@ 2016-01-05 21:06 ` Joe Hershberger
2016-01-07 16:50 ` Stefano Babic
1 sibling, 0 replies; 13+ messages in thread
From: Joe Hershberger @ 2016-01-05 21:06 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> As per the AR8031 datasheet:
>
> "For a reliable power on reset, suggest to keep asserting the reset
> low long enough (10ms) to ensure the clock is stable and clock-to-reset
> 1ms requirement is satisfied."
>
> So do as suggested and also add a 100us delay after deasserting the
> reset line to guarantee that the PHY ID can be read correctly and the
> Atheros 8031 PHY driver can be loaded automatically.
>
> This results in a simpler code.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 3/3] wandboard: Simplify the Ethernet PHY configuration
2016-01-05 19:02 ` [U-Boot] [PATCH v2 3/3] wandboard: " Fabio Estevam
2016-01-05 21:06 ` Joe Hershberger
@ 2016-01-07 16:50 ` Stefano Babic
1 sibling, 0 replies; 13+ messages in thread
From: Stefano Babic @ 2016-01-07 16:50 UTC (permalink / raw)
To: u-boot
On 05/01/2016 20:02, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> As per the AR8031 datasheet:
>
> "For a reliable power on reset, suggest to keep asserting the reset
> low long enough (10ms) to ensure the clock is stable and clock-to-reset
> 1ms requirement is satisfied."
>
> So do as suggested and also add a 100us delay after deasserting the
> reset line to guarantee that the PHY ID can be read correctly and the
> Atheros 8031 PHY driver can be loaded automatically.
>
> This results in a simpler code.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
Applied (fix) to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
2016-01-05 19:02 [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Fabio Estevam
2016-01-05 19:02 ` [U-Boot] [PATCH v2 2/3] mx6sabresd: Simplify the Ethernet PHY configuration Fabio Estevam
2016-01-05 19:02 ` [U-Boot] [PATCH v2 3/3] wandboard: " Fabio Estevam
@ 2016-01-05 19:06 ` Joe Hershberger
2016-01-06 5:17 ` Qiang Zhao
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Joe Hershberger @ 2016-01-05 19:06 UTC (permalink / raw)
To: u-boot
On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
> ar8021_config") selected 'ar8021_config' as the configuration function
> for AR8031.
>
> The correct would be to use 'ar8035_config' instead as AR8031/AR8035
> have the same programming model and even share the same phy driver
> in the linux kernel: drivers/net/phy/at803x.c.
>
> Tested on a mx6qsabresd and wandboard, which now can work without
> any PHY setup code in the board files.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
2016-01-05 19:02 [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Fabio Estevam
` (2 preceding siblings ...)
2016-01-05 19:06 ` [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Joe Hershberger
@ 2016-01-06 5:17 ` Qiang Zhao
2016-01-06 9:47 ` Fabio Estevam
2016-01-06 6:19 ` Qiang Zhao
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Qiang Zhao @ 2016-01-06 5:17 UTC (permalink / raw)
To: u-boot
On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Wednesday, January 06, 2016 3:03 AM
> To: sbabic at denx.de
> Cc: joe.hershberger at ni.com; B45475 at freescale.com; yorksun at freescale.com;
> troy.kisky at boundarydevices.com; u-boot at lists.denx.de; Fabio Estevam
> <fabio.estevam@nxp.com>
> Subject: [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
>
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
> ar8021_config") selected 'ar8021_config' as the configuration function for
> AR8031.
>
> The correct would be to use 'ar8035_config' instead as AR8031/AR8035 have
> the same programming model and even share the same phy driver in the linux
> kernel: drivers/net/phy/at803x.c.
>
> Tested on a mx6qsabresd and wandboard, which now can work without any
> PHY setup code in the board files.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> This is 2016.04 material.
>
> Zhao Qiang, could you please test this on your platform?
Yes, have tested, it can work on my platform.
>
> Changes since v1:
> - None
>
> drivers/net/phy/atheros.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index
> d509e30..ba57b1a 100644
> --- a/drivers/net/phy/atheros.c
> +++ b/drivers/net/phy/atheros.c
> @@ -51,7 +51,7 @@ static struct phy_driver AR8031_driver = {
> .uid = 0x4dd074,
> .mask = 0xffffffef,
> .features = PHY_GBIT_FEATURES,
> - .config = ar8021_config,
> + .config = ar8035_config,
> .startup = genphy_startup,
> .shutdown = genphy_shutdown,
> };
> --
> 1.9.1
Best Regards
Zhao Qiang
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
2016-01-06 5:17 ` Qiang Zhao
@ 2016-01-06 9:47 ` Fabio Estevam
2016-01-06 12:40 ` Stefano Babic
0 siblings, 1 reply; 13+ messages in thread
From: Fabio Estevam @ 2016-01-06 9:47 UTC (permalink / raw)
To: u-boot
On Wed, Jan 6, 2016 at 3:17 AM, Qiang Zhao <qiang.zhao@nxp.com> wrote:
> On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
>
>> -----Original Message-----
>> From: Fabio Estevam [mailto:festevam at gmail.com]
>> Sent: Wednesday, January 06, 2016 3:03 AM
>> To: sbabic at denx.de
>> Cc: joe.hershberger at ni.com; B45475 at freescale.com; yorksun at freescale.com;
>> troy.kisky at boundarydevices.com; u-boot at lists.denx.de; Fabio Estevam
>> <fabio.estevam@nxp.com>
>> Subject: [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
>>
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
>> ar8021_config") selected 'ar8021_config' as the configuration function for
>> AR8031.
>>
>> The correct would be to use 'ar8035_config' instead as AR8031/AR8035 have
>> the same programming model and even share the same phy driver in the linux
>> kernel: drivers/net/phy/at803x.c.
>>
>> Tested on a mx6qsabresd and wandboard, which now can work without any
>> PHY setup code in the board files.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>> ---
>> This is 2016.04 material.
>>
>> Zhao Qiang, could you please test this on your platform?
>
> Yes, have tested, it can work on my platform.
Excellent, thanks for testing, Zhao.
Stefano,
With Zhao's test I think it is safe to add this for 2016.01. What do you think?
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
2016-01-06 9:47 ` Fabio Estevam
@ 2016-01-06 12:40 ` Stefano Babic
0 siblings, 0 replies; 13+ messages in thread
From: Stefano Babic @ 2016-01-06 12:40 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 06/01/2016 10:47, Fabio Estevam wrote:
> On Wed, Jan 6, 2016 at 3:17 AM, Qiang Zhao <qiang.zhao@nxp.com> wrote:
>> On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>
>>> -----Original Message-----
>>> From: Fabio Estevam [mailto:festevam at gmail.com]
>>> Sent: Wednesday, January 06, 2016 3:03 AM
>>> To: sbabic at denx.de
>>> Cc: joe.hershberger at ni.com; B45475 at freescale.com; yorksun at freescale.com;
>>> troy.kisky at boundarydevices.com; u-boot at lists.denx.de; Fabio Estevam
>>> <fabio.estevam@nxp.com>
>>> Subject: [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
>>>
>>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>>
>>> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
>>> ar8021_config") selected 'ar8021_config' as the configuration function for
>>> AR8031.
>>>
>>> The correct would be to use 'ar8035_config' instead as AR8031/AR8035 have
>>> the same programming model and even share the same phy driver in the linux
>>> kernel: drivers/net/phy/at803x.c.
>>>
>>> Tested on a mx6qsabresd and wandboard, which now can work without any
>>> PHY setup code in the board files.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>>> ---
>>> This is 2016.04 material.
>>>
>>> Zhao Qiang, could you please test this on your platform?
>>
>> Yes, have tested, it can work on my platform.
>
> Excellent, thanks for testing, Zhao.
>
> Stefano,
>
> With Zhao's test I think it is safe to add this for 2016.01. What do you think?
>
Agree, I pick it up.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
2016-01-05 19:02 [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Fabio Estevam
` (3 preceding siblings ...)
2016-01-06 5:17 ` Qiang Zhao
@ 2016-01-06 6:19 ` Qiang Zhao
2016-01-06 9:25 ` Qiang Zhao
2016-01-07 16:50 ` Stefano Babic
6 siblings, 0 replies; 13+ messages in thread
From: Qiang Zhao @ 2016-01-06 6:19 UTC (permalink / raw)
To: u-boot
On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Wednesday, January 06, 2016 3:03 AM
> To: sbabic at denx.de
> Cc: joe.hershberger at ni.com; B45475 at freescale.com; yorksun at freescale.com;
> troy.kisky at boundarydevices.com; u-boot at lists.denx.de; Fabio Estevam
> <fabio.estevam@nxp.com>
> Subject: [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
>
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
> ar8021_config") selected 'ar8021_config' as the configuration function for
> AR8031.
>
> The correct would be to use 'ar8035_config' instead as AR8031/AR8035 have
> the same programming model and even share the same phy driver in the linux
> kernel: drivers/net/phy/at803x.c.
>
> Tested on a mx6qsabresd and wandboard, which now can work without any
> PHY setup code in the board files.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> This is 2016.04 material.
>
> Zhao Qiang, could you please test this on your platform?
Yes, have tested, it can work on my platform.
>
> Changes since v1:
> - None
>
> drivers/net/phy/atheros.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index
> d509e30..ba57b1a 100644
> --- a/drivers/net/phy/atheros.c
> +++ b/drivers/net/phy/atheros.c
> @@ -51,7 +51,7 @@ static struct phy_driver AR8031_driver = {
> .uid = 0x4dd074,
> .mask = 0xffffffef,
> .features = PHY_GBIT_FEATURES,
> - .config = ar8021_config,
> + .config = ar8035_config,
> .startup = genphy_startup,
> .shutdown = genphy_shutdown,
> };
> --
> 1.9.1
Best Regards
Zhao Qiang
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
2016-01-05 19:02 [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Fabio Estevam
` (4 preceding siblings ...)
2016-01-06 6:19 ` Qiang Zhao
@ 2016-01-06 9:25 ` Qiang Zhao
2016-01-07 16:50 ` Stefano Babic
6 siblings, 0 replies; 13+ messages in thread
From: Qiang Zhao @ 2016-01-06 9:25 UTC (permalink / raw)
To: u-boot
On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Wednesday, January 06, 2016 3:03 AM
> To: sbabic at denx.de
> Cc: joe.hershberger at ni.com; B45475 at freescale.com; yorksun at freescale.com;
> troy.kisky at boundarydevices.com; u-boot at lists.denx.de; Fabio Estevam
> <fabio.estevam@nxp.com>
> Subject: [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
>
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
> ar8021_config") selected 'ar8021_config' as the configuration function for
> AR8031.
>
> The correct would be to use 'ar8035_config' instead as AR8031/AR8035 have
> the same programming model and even share the same phy driver in the linux
> kernel: drivers/net/phy/at803x.c.
>
> Tested on a mx6qsabresd and wandboard, which now can work without any
> PHY setup code in the board files.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> This is 2016.04 material.
>
> Zhao Qiang, could you please test this on your platform?
Yes, have tested, it can work on my platform.
>
> Changes since v1:
> - None
>
> drivers/net/phy/atheros.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index
> d509e30..ba57b1a 100644
> --- a/drivers/net/phy/atheros.c
> +++ b/drivers/net/phy/atheros.c
> @@ -51,7 +51,7 @@ static struct phy_driver AR8031_driver = {
> .uid = 0x4dd074,
> .mask = 0xffffffef,
> .features = PHY_GBIT_FEATURES,
> - .config = ar8021_config,
> + .config = ar8035_config,
> .startup = genphy_startup,
> .shutdown = genphy_shutdown,
> };
> --
> 1.9.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
2016-01-05 19:02 [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Fabio Estevam
` (5 preceding siblings ...)
2016-01-06 9:25 ` Qiang Zhao
@ 2016-01-07 16:50 ` Stefano Babic
6 siblings, 0 replies; 13+ messages in thread
From: Stefano Babic @ 2016-01-07 16:50 UTC (permalink / raw)
To: u-boot
On 05/01/2016 20:02, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
> ar8021_config") selected 'ar8021_config' as the configuration function
> for AR8031.
>
> The correct would be to use 'ar8035_config' instead as AR8031/AR8035
> have the same programming model and even share the same phy driver
> in the linux kernel: drivers/net/phy/at803x.c.
>
> Tested on a mx6qsabresd and wandboard, which now can work without
> any PHY setup code in the board files.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> This is 2016.04 material.
>
> Zhao Qiang, could you please test this on your platform?
>
> Changes since v1:
> - None
>
> drivers/net/phy/atheros.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
> index d509e30..ba57b1a 100644
> --- a/drivers/net/phy/atheros.c
> +++ b/drivers/net/phy/atheros.c
> @@ -51,7 +51,7 @@ static struct phy_driver AR8031_driver = {
> .uid = 0x4dd074,
> .mask = 0xffffffef,
> .features = PHY_GBIT_FEATURES,
> - .config = ar8021_config,
> + .config = ar8035_config,
> .startup = genphy_startup,
> .shutdown = genphy_shutdown,
> };
>
Applied (fix) to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 13+ messages in thread