From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Date: Thu, 7 Jan 2016 09:23:09 -0600 Subject: [U-Boot] [PATCH] arm: socfpga: set the fpga global bit to disable HPS to FPGA signals In-Reply-To: <568E7E26.5080404@kernel.org> References: <1452109723-17059-1-git-send-email-dinguyen@opensource.altera.com> <201601070321.40398.marex@denx.de> <568DD258.9060401@kernel.org> <201601070420.23773.marex@denx.de> <568E7E26.5080404@kernel.org> Message-ID: <568E82DD.6080608@kernel.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/07/2016 09:03 AM, Dinh Nguyen wrote: > > > On 01/06/2016 09:20 PM, Marek Vasut wrote: >> On Thursday, January 07, 2016 at 03:50:00 AM, Dinh Nguyen wrote: >>> On 01/06/2016 08:21 PM, Marek Vasut wrote: >>>> On Wednesday, January 06, 2016 at 08:48:43 PM, >>>> dinguyen at opensource.altera.com >>>> >>>> wrote: >>>>> From: Dinh Nguyen >>>>> >>>>> We should be setting the FPGA Interface Group global bit that will >>>>> correctly disable all interfaces between the FPGA and HPS. >>>>> >>>>> Signed-off-by: Dinh Nguyen >>>>> --- >>>>> >>>>> drivers/fpga/socfpga.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c >>>>> index 4448250..431e159 100644 >>>>> --- a/drivers/fpga/socfpga.c >>>>> +++ b/drivers/fpga/socfpga.c >>>>> @@ -269,7 +269,7 @@ int socfpga_load(Altera_desc *desc, const void >>>>> *rbf_data, size_t rbf_size) /* Prior programming the FPGA, all bridges >>>>> need to be shut off */ >>>>> >>>>> /* Disable all signals from hps peripheral controller to fpga */ >>>>> >>>>> - writel(0, &sysmgr_regs->fpgaintfgrp_module); >>>>> + writel(0, &sysmgr_regs->fpgaintfgrp_gbl); >>>>> >>>>> /* Disable all signals from FPGA to HPS SDRAM */ >>>>> >>>>> #define SDR_CTRLGRP_FPGAPORTRST_ADDRESS 0x5080 >>>> >>>> Looks fine, >>>> >>>> Acked-by: Marek Vasut >>>> >>>> btw Shouldn't you also fix the same thing in drivers/fpga/socfpga.c ? >>>> Even >>> >>> I'm confused by what you mean here. The patch is for >>> drivers/fpga/socfpga.c. >> >> Oops, sorry, there is another one in arch/arm/mach-socfpga/misc.c . I mispasted >> the wrong filename. >> > > Ah yes, then we should probably add a function to enable/disable the > interfaces. > But I wonder if I wanted to enable the individual interfaces, i.e. the separate EMACs that is in fpgaintfgrp_module, would I need to enable the fpgaintfgrp_gbl bit? Dinh