From: Lev Iserovich <Lev.Iserovich@deshawresearch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: fix setting MAC addresses for multiple interfaces
Date: Thu, 7 Jan 2016 15:21:14 -0500 [thread overview]
Message-ID: <568EC8BA.9070602@deshawresearch.com> (raw)
In-Reply-To: <CAEUhbmX8X5SyM3Cu8EgT=6WqxWBo43LUtPjZc=nC_z8f=4RNsg@mail.gmail.com>
Hi Bin,
On 01/06/2016 09:42 PM, Bin Meng wrote:
> Could you please elaborate more under what situation the offset of
> '/aliases' will change?
I believe the offset of '/aliases' will change because we're editing the
device tree in place (adding the MAC address to it where it wasn't before),
and 'aliases' is at the very end of the device tree.
I've seen this happen on my board (Freescale LS1043A-RDB).
I added some debugging printf's to my code, and saw that all ethernet
interfaces after ethernet0 get a 'FDT_ERR_BADOFFSET' from the
fdt_getprop() call , and Linux comes up with only 1 interface.
After this fix all the interfaces come up properly in Linux with the
right MAC addresses.
> Can you please rebase your patch on top of the following two:
>
> http://patchwork.ozlabs.org/patch/539373/
> http://patchwork.ozlabs.org/patch/539374/
The second patch seems like a rewrite of the scan through interfaces
loop, so it's not a simple rebase.
I will attempt to do this, and send another patch soon.
Thanks,
Lev
next prev parent reply other threads:[~2016-01-07 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 21:01 [U-Boot] [PATCH] fdt: fix setting MAC addresses for multiple interfaces Lev Iserovich
2016-01-07 2:42 ` Bin Meng
2016-01-07 20:21 ` Lev Iserovich [this message]
2016-01-07 23:04 ` [U-Boot] [PATCH v2] " Lev Iserovich
2016-04-26 19:27 ` Joe Hershberger
2016-04-27 0:06 ` Bin Meng
2016-04-27 1:57 ` Bin Meng
2016-05-02 17:12 ` Joe Hershberger
2016-05-02 16:01 ` Lev Iserovich
2016-05-03 19:52 ` Joe Hershberger
2016-05-04 14:44 ` Lev Iserovich
2016-05-03 20:16 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568EC8BA.9070602@deshawresearch.com \
--to=lev.iserovich@deshawresearch.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox