From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 8 Jan 2016 06:53:10 +0100 Subject: [U-Boot] [RFC v2 PATCH] get_maintainer: fix perl 5.22/5.24 deprecated/incompatible "\C" use In-Reply-To: <20160107161359.5ED03380311@gemini.denx.de> References: <1452170739-31351-1-git-send-email-hs@denx.de> <20160107161359.5ED03380311@gemini.denx.de> Message-ID: <568F4EC6.3030601@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, Am 07.01.2016 um 17:13 schrieb Wolfgang Denk: > Dear Heiko, > > In message <1452170739-31351-1-git-send-email-hs@denx.de> you wrote: >> >> running get_maintainer.pl drops warnings with PERL > 5.22 . >> In linux this is fixed though above commit. > > ACK. > >> But ... I get differences when running the python script: > > So the Python script ... > >> ret = subprocess.call(["scripts/get_maintainer.pl", "-f", tmp]) > > ...basically does the equivalent of running > > scripts/get_maintainer.pl -f / > > on the command line. Yes... the script does this just for *all* files in the u-boot tree. >> and comparing the output from it, based on the original >> u-boot code and the code with this patch ... > > What exactly do you mean by "I get differences"? What are the used > values for "directory" and "file" in your test case, and which exact > differences do you get? I do exactly (should have written this to the commit text ... sorry): - python2.7 check_get.py > ../gnlmpf_org - Apply this patch (with "patch" not with "git am") to the u-boot tree - python2.7 check_get.py > ../gnlmpf_new - diff -purN ../gnlmpf_org ../gnlmpf_new > ../gnlmpf So I expect only a difference in the "scripts/get_maintainer.pl" file, as no other file has changed, also no change in the git files... First difference: --- ../gnlmpf_org 2016-01-07 13:39:39.059124449 +0100 +++ ../gnlmpf_new 2016-01-07 13:41:57.937391203 +0100 @@ -1,12 +1,11 @@ -Masahiro Yamada (commit_signer:1/1=100%) Jagan Teki (commit_signer:1/1=100%,authored:1/1=100%) +Masahiro Yamada (commit_signer:1/1=100%) u-boot at lists.denx.de (open list) Masahiro Yamada (commit_signer:2/4=50%,authored:2/4=50%) +Stefan Roese (commit_signer:1/4=25%) Joe Hershberger (commit_signer:1/4=25%,authored:1/4=25%) Marek Vasut (commit_signer:1/4=25%) -Stefan Roese (commit_signer:1/4=25%) -York Sun (commit_signer:1/4=25%) -Simon Glass (authored:1/4=25%) +Simon Glass (commit_signer:1/4=25%,authored:1/4=25%) u-boot at lists.denx.de (open list) Masahiro Yamada (commit_signer:14/24=58%,authored:14/24=58%) Stefan Roese (commit_signer:4/24=17%) The "Masahiro" and the "Simon" diff are only a diff in the order, but "York Sun" is missing complete ... bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany